xiaoxue_admin
/
zvec
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor: remove unused validation in c api (#388)

This commit is contained in:
Qinren Zhou 2026-05-08 19:04:45 +08:00 committed by GitHub
parent 1d4ae0b1b5
commit cfe9eed2f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/binding/c/c_api.cc
View File

@ -4307,37 +4307,6 @@ size_t zvec_doc_memory_usage(const zvec_doc_t *doc) {
return doc_ptr->memory_usage();)
}
zvec_error_code_t zvec_doc_validate_and_sanitize(zvec_doc_t *doc,
const zvec_collection_schema_t *schema,
bool is_update, char **error_msg) {
if (!doc || !schema) {
set_last_error("Document or schema pointer is null");
return ZVEC_ERROR_INVALID_ARGUMENT;
}
ZVEC_TRY_RETURN_ERROR(
"Failed to validate document",
std::shared_ptr<zvec::CollectionSchema> schema_ptr = nullptr;
auto status =
convert_zvec_collection_schema_to_internal(schema, schema_ptr);
if (!status.ok()) {
if (error_msg) {
*error_msg = copy_string(status.message());
}
return status_to_error_code(status);
}
auto doc_ptr = reinterpret_cast<zvec::Doc *>(doc);
status = doc_ptr->validate_and_sanitize(schema_ptr, is_update); if (!status.ok()) {
if (error_msg) {
*error_msg = copy_string(status.message());
}
return status_to_error_code(status);
}
if (error_msg) { *error_msg = nullptr; }
return ZVEC_OK;)
}
zvec_error_code_t zvec_doc_to_detail_string(const zvec_doc_t *doc, char **detail_str) {
if (!doc || !detail_str) {

12
src/include/zvec/c_api.h
View File

@ -3035,18 +3035,6 @@ ZVEC_EXPORT void ZVEC_CALL zvec_doc_merge(zvec_doc_t *doc,
*/
ZVEC_EXPORT size_t ZVEC_CALL zvec_doc_memory_usage(const zvec_doc_t *doc);
/**
* @brief Validate document against Schema
*
* @param doc Document object pointer
* @param schema Schema object pointer
* @param is_update Whether it's an update operation
* @param[out] error_msg Error message (needs manual release)
* @return zvec_error_code_t Error code
*/
ZVEC_EXPORT zvec_error_code_t ZVEC_CALL zvec_doc_validate_and_sanitize(
zvec_doc_t *doc, const zvec_collection_schema_t *schema, bool is_update,
char **error_msg);
/**
* @brief Get detailed string representation of document

10
tests/c/c_api_test.c
View File

@ -4783,14 +4783,6 @@ void test_doc_advanced_functions(void) {
zvec_doc_add_field_by_value(val_doc, "test_field", ZVEC_DATA_TYPE_INT32,
&(int32_t){42}, sizeof(int32_t));
char *error_msg = NULL;
zvec_error_code_t err =
zvec_doc_validate_and_sanitize(val_doc, schema, false, &error_msg);
TEST_ASSERT(err == ZVEC_OK);
if (error_msg) {
zvec_free(error_msg);
}
zvec_doc_destroy(val_doc);
zvec_collection_schema_destroy(schema);
zvec_doc_destroy(doc);
@ -4804,7 +4796,7 @@ void test_doc_advanced_functions(void) {
"hello", 5);
char *detail_str = NULL;
err = zvec_doc_to_detail_string(detail_doc, &detail_str);
zvec_error_code_t err = zvec_doc_to_detail_string(detail_doc, &detail_str);
TEST_ASSERT(err == ZVEC_OK);
TEST_ASSERT(detail_str != NULL);
// printf(" Document detail: %s\n", detail_str);