xiaoxue_admin
/
zvec
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: skip drive root in Windows MakePath (#337) 

CreateDirectoryA("C:", nullptr) returns ERROR_ACCESS_DENIED on Windows
(not ERROR_ALREADY_EXISTS), causing MakePath to fail immediately for any
path on the C: drive. Skip the CreateDirectoryA call when the intermediate
path is a bare drive root (e.g. "C:").
This commit is contained in:
Jalin Wang 2026-04-14 19:01:37 +08:00 committed by GitHub
parent 8f2d0e30a1
commit 09f93c5869
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ailego/utility/file_helper.cc
View File

@ -297,7 +297,11 @@ bool FileHelper::MakePath(const char *path) {
// Neither root nor double slash in path
if (sp != pp) {
*sp = '\0';
if (!CreateDirectoryA(pathbuf, nullptr) &&
// Skip Windows drive roots like "C:" — CreateDirectoryA on a bare drive
// letter returns ERROR_ACCESS_DENIED (not ERROR_ALREADY_EXISTS), which
// would cause MakePath to fail even when all parent dirs already exist.
bool is_drive_root = (sp - pathbuf == 2 && pathbuf[1] == ':');
if (!is_drive_root && !CreateDirectoryA(pathbuf, nullptr) &&
GetLastError() != ERROR_ALREADY_EXISTS) {
return false;
}