fix: use platform separators for default workspace dir (#3873)

This commit is contained in:
Jinwoo Hong 2026-05-30 15:49:42 -04:00 committed by GitHub
parent 247dc7158b
commit fb5580a50a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions

View File

@ -2,6 +2,13 @@ import { describe, expect, it } from 'vitest'
import { getDefaultPrimarySelectionMiddleClickPaste, getDefaultSettings } from './constants'
describe('getDefaultSettings', () => {
it('uses platform-consistent separators for the default workspace directory', () => {
expect(getDefaultSettings('/Users/alice').workspaceDir).toBe('/Users/alice/orca/workspaces')
expect(getDefaultSettings('C:\\Users\\alice').workspaceDir).toBe(
'C:\\Users\\alice\\orca\\workspaces'
)
})
it('enables gitignored file decorations by default', () => {
expect(getDefaultSettings('/tmp').showGitIgnoredFiles).toBe(true)
})

View File

@ -154,9 +154,15 @@ export function getDefaultOnboardingState(): OnboardingState {
}
}
function getDefaultWorkspaceDir(homeDir: string): string {
const separator = homeDir.includes('\\') ? '\\' : '/'
const trimmedHomeDir = homeDir.replace(/[\\/]+$/, '')
return [trimmedHomeDir, 'orca', 'workspaces'].join(separator)
}
export function getDefaultSettings(homedir: string): GlobalSettings {
return {
workspaceDir: `${homedir}/orca/workspaces`,
workspaceDir: getDefaultWorkspaceDir(homedir),
nestWorkspaces: true,
workspaceDirHistory: [],
refreshLocalBaseRefOnWorktreeCreate: false,