xiaoxue_admin
/
orca
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: clean combobox focus frame effects (#4010)

This commit is contained in:
Neil 2026-05-31 01:07:57 -07:00 committed by GitHub
parent 3647b53e00
commit e6c525b01e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/renderer/src/components/agent/AgentCombobox.tsx
View File

@ -146,7 +146,15 @@ export default function AgentCombobox({
}
}, [])
React.useEffect(() => cancelFocusFrame, [cancelFocusFrame])
const setInputNode = useCallback(
(node: HTMLInputElement | null): void => {
if (node === null) {
cancelFocusFrame()
}
inputRef.current = node
},
[cancelFocusFrame]
)
React.useEffect(() => {
if (!open) {
@ -284,7 +292,7 @@ export default function AgentCombobox({
>
<Command shouldFilter={false} value={commandValue} onValueChange={setCommandValue}>
<CommandInput
ref={inputRef}
ref={setInputNode}
placeholder="Search agents..."
value={query}
onValueChange={setQuery}

12
src/renderer/src/components/automations/WorkspaceCombobox.tsx
View File

@ -35,7 +35,15 @@ export function WorkspaceCombobox({
}
}, [])
React.useEffect(() => cancelFocusFrame, [cancelFocusFrame])
const setInputNode = React.useCallback(
(node: HTMLInputElement | null): void => {
if (node === null) {
cancelFocusFrame()
}
inputRef.current = node
},
[cancelFocusFrame]
)
const focusSearchInput = React.useCallback(() => {
cancelFocusFrame()
@ -80,7 +88,7 @@ export function WorkspaceCombobox({
}}
>
<Command>
<CommandInput ref={inputRef} placeholder="Search workspaces..." />
<CommandInput ref={setInputNode} placeholder="Search workspaces..." />
<CommandList className="max-h-72">
<CommandEmpty>No workspaces found.</CommandEmpty>
{worktrees.map((worktree) => (

12
src/renderer/src/components/repo/RepoCombobox.tsx
View File

@ -65,7 +65,15 @@ export default function RepoCombobox({
}
}, [])
React.useEffect(() => cancelFocusFrame, [cancelFocusFrame])
const setInputNode = useCallback(
(node: HTMLInputElement | null): void => {
if (node === null) {
cancelFocusFrame()
}
inputRef.current = node
},
[cancelFocusFrame]
)
const focusSearchInput = useCallback(() => {
cancelFocusFrame()
@ -215,7 +223,7 @@ export default function RepoCombobox({
>
<Command shouldFilter={false} value={commandValue} onValueChange={setCommandValue}>
<CommandInput
ref={inputRef}
ref={setInputNode}
placeholder="Search projects/folders..."
value={query}
onValueChange={setQuery}