fix: align issue hover action order (#5545)

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Jinwoo Hong 2026-06-16 17:24:47 -07:00 committed by GitHub
parent 67a95c7400
commit c334f2cc6f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 41 additions and 11 deletions

View File

@ -94,6 +94,36 @@ describe('WorktreeCardDetailsHover', () => {
expect(markup).not.toContain('aria-label="Unlink PR"')
})
it('puts issue edit before open actions and keeps GitHub last', () => {
const markup = renderToStaticMarkup(
<WorktreeCardDetailsHover
issue={{
number: 5518,
title: 'Agent monitor lists ephemeral headless subprocesses',
state: 'closed',
url: 'https://github.com/acme/orca/issues/5518',
labels: []
}}
linearIssue={null}
review={null}
comment={null}
onEditIssue={vi.fn()}
onEditComment={vi.fn()}
onOpenGitHubIssueInOrca={vi.fn()}
>
<span>Linked issue</span>
</WorktreeCardDetailsHover>
)
const editIssueIndex = markup.indexOf('aria-label="Edit issue"')
const openInOrcaIndex = markup.indexOf('aria-label="Open in Orca"')
const viewOnGitHubIndex = markup.indexOf('aria-label="View on GitHub"')
expect(editIssueIndex).toBeGreaterThan(-1)
expect(editIssueIndex).toBeLessThan(openInOrcaIndex)
expect(openInOrcaIndex).toBeLessThan(viewOnGitHubIndex)
})
it('labels GitLab unlink actions with MR terminology', () => {
const markup = renderToStaticMarkup(
<WorktreeCardDetailsHover

View File

@ -209,6 +209,17 @@ export function WorktreeCardDetailsHover({
)}
actions={
<>
{onEditIssue && (
<MetadataActionIcon
label={translate(
'auto.components.sidebar.WorktreeCardMeta.807b13b9ec',
'Edit issue'
)}
onClick={onEditIssue}
>
<Pencil className="size-3" />
</MetadataActionIcon>
)}
{issue.url && onOpenGitHubIssueInOrca && (
<MetadataActionIcon
label={translate(
@ -231,17 +242,6 @@ export function WorktreeCardDetailsHover({
<ExternalLink className="size-3" />
</MetadataActionIcon>
)}
{onEditIssue && (
<MetadataActionIcon
label={translate(
'auto.components.sidebar.WorktreeCardMeta.807b13b9ec',
'Edit issue'
)}
onClick={onEditIssue}
>
<Pencil className="size-3" />
</MetadataActionIcon>
)}
</>
}
/>