Remove feature wall persisted close reset effect (#3188)

This commit is contained in:
Neil 2026-05-30 12:41:36 -07:00 committed by GitHub
parent 2da9c85647
commit 4ea2eae432
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 20 deletions

View File

@ -68,7 +68,7 @@ export function useFeatureWallCompletion(
: false)
const [hasUsageAccount, setHasUsageAccount] = useState(false)
const persistedCompletion = usePersistedFeatureWallCompletion(isOpen)
const persistedCompletion = usePersistedFeatureWallCompletion()
const {
visitedWorkflows,
visitedAgentSteps,

View File

@ -1,4 +1,4 @@
import { useCallback, useEffect, useState } from 'react'
import { useCallback, useState } from 'react'
import type { Dispatch, SetStateAction } from 'react'
import type { AgentsStepId } from '../../../../shared/agents-orchestration-steps'
import type { FeatureWallWorkflowId } from '../../../../shared/feature-wall-workflows'
@ -53,9 +53,7 @@ function addToSet<T>(setValue: Dispatch<SetStateAction<Set<T>>>, id: T): void {
})
}
export function usePersistedFeatureWallCompletion(
isOpen: boolean
): PersistedFeatureWallCompletionState {
export function usePersistedFeatureWallCompletion(): PersistedFeatureWallCompletionState {
const [visitedWorkflows, setVisitedWorkflows] = useState<Set<FeatureWallWorkflowId>>(() =>
readPersistedVisitedWorkflows()
)
@ -81,21 +79,6 @@ export function usePersistedFeatureWallCompletion(
readPersistedCompletedReviewSteps()
)
// Reset from persisted state on close so another window or tab's tour visit
// is reflected the next time this modal opens.
useEffect(() => {
if (!isOpen) {
setVisitedWorkflows(readPersistedVisitedWorkflows())
setVisitedAgentSteps(readPersistedVisitedAgentSteps())
setVisitedWorkbenchSteps(readPersistedVisitedWorkbenchSteps())
setVisitedReviewSteps(readPersistedVisitedReviewSteps())
setCompletedWorkflows(readPersistedCompletedWorkflows())
setCompletedAgentSteps(readPersistedCompletedAgentSteps())
setCompletedWorkbenchSteps(readPersistedCompletedWorkbenchSteps())
setCompletedReviewSteps(readPersistedCompletedReviewSteps())
}
}, [isOpen])
const markWorkflowVisited = useCallback((id: FeatureWallWorkflowId): void => {
persistVisitedWorkflow(id)
addToSet(setVisitedWorkflows, id)