Change floating workspace shortcut default (#2678)

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Jinwoo Hong 2026-05-24 15:03:08 -04:00 committed by GitHub
parent 15995f5573
commit 3d85148e95
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 13 deletions

View File

@ -494,7 +494,7 @@ describe('createRemoteRuntimePtyTransport', () => {
expect(transport.getPtyId()).toBeNull()
})
it('processes remote data chunks through title, bell, and OSC 9999 handlers before onData', async () => {
it('delivers cleaned remote data before deferred title, bell, and OSC 9999 handlers', async () => {
const { createRemoteRuntimePtyTransport } = await import('./remote-runtime-pty-transport')
const onData = vi.fn()
const onTitleChange = vi.fn()
@ -515,6 +515,7 @@ describe('createRemoteRuntimePtyTransport', () => {
'before\x1b]9999;{"state":"working","prompt":"ship it","agentType":"codex"}\x07after\x1b]0;. Claude working\x07\x07'
)
expect(onData).toHaveBeenCalledWith('beforeafter\x1b]0;. Claude working\x07\x07')
await vi.waitFor(() =>
expect(onAgentStatus).toHaveBeenCalledWith({
state: 'working',
@ -522,7 +523,6 @@ describe('createRemoteRuntimePtyTransport', () => {
agentType: 'codex'
})
)
expect(onData).toHaveBeenCalledWith('beforeafter\x1b]0;. Claude working\x07\x07')
expect(onTitleChange).toHaveBeenCalledWith('. Claude working', '. Claude working')
expect(onBell).toHaveBeenCalledTimes(1)
})
@ -548,6 +548,7 @@ describe('createRemoteRuntimePtyTransport', () => {
'before\x1b]9999;{"state":"working","prompt":"ship it","agentType":"codex"}\x07after'
)
expect(onData).toHaveBeenCalledWith('beforeafter')
await vi.waitFor(() =>
expect(onAgentStatus).toHaveBeenCalledWith({
state: 'working',
@ -555,7 +556,6 @@ describe('createRemoteRuntimePtyTransport', () => {
agentType: 'codex'
})
)
expect(onData).toHaveBeenCalledWith('beforeafter')
})
it('resubscribes without surfacing a PTY error when the remote runtime subscription closes', async () => {

View File

@ -192,7 +192,7 @@ describe('keybindings', () => {
expect(
keybindingMatchesAction(
'floatingTerminal.toggle',
{ key: 't', code: 'KeyT', control: true, meta: false, alt: true, shift: false },
{ key: 'a', code: 'KeyA', control: true, meta: false, alt: true, shift: false },
'linux',
undefined,
{ context: 'terminal', terminalShortcutPolicy: 'terminal-first' }

View File

@ -317,7 +317,7 @@ export const KEYBINDING_DEFINITIONS: readonly KeybindingDefinition[] = [
group: 'Global',
scope: 'global',
searchKeywords: ['shortcut', 'floating terminal', 'terminal'],
defaultBindings: platformBindings(['Mod+Alt+T']),
defaultBindings: platformBindings(['Mod+Alt+A']),
allowInTerminal: true
},
{

View File

@ -347,8 +347,8 @@ describe('resolveWindowShortcutAction', () => {
expect(
resolveWindowShortcutAction(
{
code: 'KeyT',
key: 't',
code: 'KeyA',
key: 'a',
meta: true,
control: false,
alt: true,
@ -361,8 +361,8 @@ describe('resolveWindowShortcutAction', () => {
expect(
resolveWindowShortcutAction(
{
code: 'KeyT',
key: 't',
code: 'KeyA',
key: 'a',
meta: false,
control: true,
alt: true,
@ -377,8 +377,8 @@ describe('resolveWindowShortcutAction', () => {
expect(
resolveWindowShortcutAction(
{
code: 'KeyT',
key: 't',
code: 'KeyA',
key: 'a',
meta: true,
control: false,
alt: true,
@ -391,8 +391,8 @@ describe('resolveWindowShortcutAction', () => {
expect(
resolveWindowShortcutAction(
{
code: 'KeyT',
key: 't',
code: 'KeyA',
key: 'a',
meta: true,
control: true,
alt: true,