xiaoxue_admin
/
orca
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move kanban drag ref mirrors out of effects (#3067) 

* Move kanban drag ref mirrors out of effects

* Record kanban drag ref effect cleanup audit
This commit is contained in:
Neil 2026-05-29 02:53:59 -07:00 committed by GitHub
parent 3895662c01
commit 2a5601da64
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/reference/react-performance-audit.md
View File

@ -47,7 +47,7 @@ Initial inventory:
## Coverage Ledger
Current count after low-risk PRs #3038, #3041, #3042, #3044, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3062, #3063, #3064, #3065, and #3066: 940 Effect hook call sites.
Current count after low-risk PRs #3038, #3041, #3042, #3044, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3062, #3063, #3064, #3065, #3066, and #3067: 938 Effect hook call sites.
| Area | Files / signal | Scan status | Notes |
| ------------------------------ | -------------------------------------------------------------------------------------------------------- | --------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------- |
@ -98,6 +98,7 @@ These are candidate batches, not final conclusions. Each item needs code inspect
| PR X | Terminal quick-command dialog draft | Dialog draft and agent preset search are reset in an Effect after the dialog opens or retargets. | `TerminalQuickCommandDialog.tsx` covered by #3064 | Low |
| PR Y | Onboarding notification settings ref | A ref mirror Effect keeps notification handlers pointed at the latest settings. | `NotificationStep.tsx` covered by #3065 | Low |
| PR Z | Onboarding agent-selection ref mirrors | Five ref mirror Effects keep stable onboarding handlers pointed at latest selection/detection snapshots. | `use-onboarding-flow.ts` covered by #3066 | Low |
| PR AA | Workspace board drag ref mirrors | Area-selection and card-drag pointer handlers receive latest board callbacks through Effect-updated refs. | `use-workspace-kanban-area-selection.ts`, `use-workspace-kanban-card-pointer-drag.ts` covered by #3067 | Low |
## Merge Risk Scale
@ -129,6 +130,7 @@ These are candidate batches, not final conclusions. Each item needs code inspect
| #3064 | `nwparker/react-perf-quick-command-dialog` | Terminal quick-command dialog resets draft state during render | Low | Merged | `pnpm exec oxlint src/renderer/src/components/terminal-quick-commands/TerminalQuickCommandDialog.tsx`; `pnpm run typecheck:web`. |
| #3065 | `nwparker/react-perf-notification-step-ref` | Onboarding notification settings ref mirror moves out of an Effect | Low | Merged | `pnpm exec oxlint src/renderer/src/components/onboarding/NotificationStep.tsx`; `pnpm run typecheck:web`. |
| #3066 | `nwparker/react-perf-onboarding-agent-refs` | Onboarding agent-selection ref mirrors move out of Effects | Low | Merged | `pnpm exec oxlint src/renderer/src/components/onboarding/use-onboarding-flow.ts`; `pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/onboarding/agent-picked-payload.test.ts`; `pnpm run typecheck:web`. |
| #3067 | `nwparker/react-perf-kanban-drag-refs` | Workspace board drag ref mirrors move out of Effects | Low | Merged | `pnpm exec oxlint src/renderer/src/components/sidebar/use-workspace-kanban-area-selection.ts src/renderer/src/components/sidebar/use-workspace-kanban-card-pointer-drag.ts`; `pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/sidebar/use-workspace-kanban-card-pointer-drag.test.ts src/renderer/src/components/sidebar/workspace-kanban-area-selection.test.ts`; `pnpm run typecheck:web`. |
## Reproduction Commands

6
src/renderer/src/components/sidebar/use-workspace-kanban-area-selection.ts
View File

@ -76,9 +76,9 @@ export function useWorkspaceKanbanAreaSelection({
const dragRef = useRef<AreaSelectionDragState | null>(null)
const updateSelectionForAreaRef = useRef(updateSelectionForArea)
useEffect(() => {
updateSelectionForAreaRef.current = updateSelectionForArea
}, [updateSelectionForArea])
// Why: pointer handlers are stable while selection commits must call the
// latest board-selection updater before the next event can fire.
updateSelectionForAreaRef.current = updateSelectionForArea
const cancelAreaSelectionDrag = useCallback(() => {
const state = dragRef.current

18
src/renderer/src/components/sidebar/use-workspace-kanban-card-pointer-drag.ts
View File

@ -104,15 +104,15 @@ export function useWorkspaceKanbanCardPointerDrag({
const dragTargetChangeRef = useRef(onDragTargetChange)
const pinDragTargetChangeRef = useRef(onPinDragTargetChange)
useEffect(() => {
selectedWorktreeIdsRef.current = selectedWorktreeIds
selectedWorktreesRef.current = selectedWorktrees
dropWorktreesInStatusRef.current = onDropWorktreesInStatus
shouldShowDropIndicatorRef.current = onShouldShowDropIndicator
pinWorktreesRef.current = onPinWorktrees
dragTargetChangeRef.current = onDragTargetChange
pinDragTargetChangeRef.current = onPinDragTargetChange
})
// Why: document-level pointer handlers stay stable during drags, but their
// selection/drop refs must reflect the latest board state before events run.
selectedWorktreeIdsRef.current = selectedWorktreeIds
selectedWorktreesRef.current = selectedWorktrees
dropWorktreesInStatusRef.current = onDropWorktreesInStatus
shouldShowDropIndicatorRef.current = onShouldShowDropIndicator
pinWorktreesRef.current = onPinWorktrees
dragTargetChangeRef.current = onDragTargetChange
pinDragTargetChangeRef.current = onPinDragTargetChange
const clearDragTarget = useCallback(() => {
dragTargetChangeRef.current(null)