fix(config): don't write chunking defaults in cfg.init()

`cfg.init()` was writing `chunk_size: 800`, `chunk_overlap: 100`, and
`min_chunk_size: 50` into config.json on first run. The values are the
module-level defaults from `miner.py`, which is fine for `miner.py`'s
own consumers — but `convo_miner.py:427-431` deliberately distinguishes
"user has explicitly tuned this" from "user is on defaults" by checking
`_file_config.get("min_chunk_size") is None`. Writing the miner.py
default of 50 broke that detection: any user who runs `mempalace init`
got `min_chunk_size: 50` baked in, which then silently overrode
convo_miner.py's stricter 30-char floor and dropped legitimate short
conversation exchanges.

Surfaced by a pytest fixture leak: tests/conftest.py:21-27 redirects
HOME to a session-tmp dir. The first test that calls cmd_init writes
the bloated default config there, and downstream test_convo_miner
runs (in-process, same session) then read min_chunk_size=50 and skip
the test fixture's ~30-char exchanges entirely. Repro:

    pytest tests/test_cli.py::test_cmd_init_honors_palace_flag \
           tests/test_convo_miner.py::test_convo_mining

Both tests pass in isolation but the second fails when chained.

Fix: drop the chunking keys from `cfg.init()`'s default-config-write.
The `MempalaceConfig.chunk_size`/`.chunk_overlap`/`.min_chunk_size`
properties already provide the right fallbacks via
`_file_config.get(key, default)` when the key is absent. Users who
want to tune chunking still set the keys explicitly; the contract
convo_miner.py relies on (`is None` ⇔ "untuned") is restored.

Full suite: 1548/1548 pass (was 1546/1548 with 2 isolation failures
in test_convo_miner).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
jp
2026-05-10 18:11:33 -07:00
co-authored by Claude Opus 4.7
parent d20ae4f3f5
commit 1cc2876b0c
+8
View File
@@ -428,6 +428,14 @@ class MempalaceConfig:
except (OSError, NotImplementedError):
pass # Windows doesn't support Unix permissions
if not self._config_file.exists():
# Chunking parameters (chunk_size, chunk_overlap, min_chunk_size)
# are intentionally NOT written here — convo_miner.py distinguishes
# "user has tuned this" from "user is on defaults" by checking
# ``_file_config.get("min_chunk_size") is None``. Writing the
# miner.py defaults (50) into config.json breaks that detection
# and silently overrides convo_miner's stricter 30-char floor,
# dropping legitimate short conversation exchanges. Module-level
# defaults already apply correctly when these keys are absent.
default_config = {
"palace_path": DEFAULT_PALACE_PATH,
"collection_name": DEFAULT_COLLECTION_NAME,