chore: use approve command for contributor gate
This commit is contained in:
parent
b11c756ad9
commit
a9c8de7eec
|
|
@ -2,7 +2,7 @@ name: Approve Contributor
|
|||
|
||||
on:
|
||||
issue_comment:
|
||||
types: [created]
|
||||
types: [created, edited]
|
||||
|
||||
jobs:
|
||||
approve:
|
||||
|
|
@ -29,8 +29,8 @@ jobs:
|
|||
const commentBody = context.payload.comment.body || '';
|
||||
const approvedFile = '.github/APPROVED_CONTRIBUTORS';
|
||||
|
||||
if (!/^\s*lgtm\b/i.test(commentBody)) {
|
||||
console.log('Comment does not match lgtm');
|
||||
if (!/(^|\s)\/approve(?=$|\s)/i.test(commentBody)) {
|
||||
console.log('Comment does not contain /approve');
|
||||
core.setOutput('status', 'skipped');
|
||||
return;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -109,7 +109,7 @@ jobs:
|
|||
'**Next steps:**',
|
||||
'1. Open an issue describing what you want to change and why',
|
||||
'2. Keep it concise and write in your own voice',
|
||||
'3. If a maintainer approves with `lgtm`, you will be added to the approved contributors list',
|
||||
'3. If a maintainer approves with `/approve`, you will be added to the approved contributors list',
|
||||
'4. Then you can submit your PR',
|
||||
'',
|
||||
`This PR will be closed automatically. See https://github.com/${context.repo.owner}/${context.repo.repo}/blob/${defaultBranch}/CONTRIBUTING.md for more details.`,
|
||||
|
|
|
|||
|
|
@ -26,7 +26,7 @@ If you have a suggestion, disagreement, or contradiction with the current produc
|
|||
|
||||
We use an approval gate for new contributors.
|
||||
|
||||
Before opening your first PR, open an issue describing what you want to change and why. Keep it short. Write in your own voice. If you intend to implement it yourself, add the `intends-to-pr` label. A maintainer will comment `lgtm` if the direction is approved. Once approved, you can open PRs.
|
||||
Before opening your first PR, open an issue describing what you want to change and why. Keep it short. Write in your own voice. If you intend to implement it yourself, add the `intends-to-pr` label. A maintainer will comment `/approve` if the direction is approved. Once approved, you can open PRs.
|
||||
|
||||
This exists because AI makes it trivial to generate plausible-looking contributions that do not fit the app.
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue