xiaoxue_admin
/
dbx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(sidebar): keep connection expansion stable

This commit is contained in:
t8y2 2026-05-23 01:32:51 +08:00
parent 7a3ff3bff9
commit 5f19dccdc1
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/src/components/sidebar/ConnectionTree.vue
View File

@ -15,6 +15,7 @@ import {
SIDEBAR_TREE_SCROLL_BUFFER,
flattenTree,
scrollTopForExpandedTreeNode,
shouldAutoScrollExpandedTreeNode,
shouldVirtualizeFlatTree,
type FlatTreeNode,
} from "@/composables/useFlatTree";
@ -144,6 +145,7 @@ function onSearchToggle(node: TreeNode) {
async function onNodeToggled(node: TreeNode, wasExpanded: boolean) {
if (wasExpanded || !node.isExpanded) return;
if (!shouldAutoScrollExpandedTreeNode(node.type)) return;
await nextTick();

4
apps/desktop/src/composables/useFlatTree.ts
View File

@ -30,6 +30,10 @@ export function shouldVirtualizeFlatTree(count: number): boolean {
return count > 0;
}
export function shouldAutoScrollExpandedTreeNode(type: TreeNodeType): boolean {
return type !== "connection" && type !== "connection-group";
}
export function scrollTopForExpandedTreeNode(options: {
expandedIndex: number;
insertedRowCount: number;

8
packages/app-tests/useFlatTree.test.ts
View File

@ -6,6 +6,7 @@ import {
SIDEBAR_TREE_SCROLL_BUFFER,
flattenTree,
scrollTopForExpandedTreeNode,
shouldAutoScrollExpandedTreeNode,
shouldVirtualizeFlatTree,
} from "../../apps/desktop/src/composables/useFlatTree.ts";
import type { TreeNode } from "../../apps/desktop/src/types/database.ts";
@ -59,6 +60,13 @@ test("sidebar virtual tree prerenders enough rows for the first frame", () => {
assert.ok(SIDEBAR_TREE_PRERENDER_COUNT >= 40);
});
test("sidebar keeps root connection expansion from changing scroll position", () => {
assert.equal(shouldAutoScrollExpandedTreeNode("connection"), false);
assert.equal(shouldAutoScrollExpandedTreeNode("connection-group"), false);
assert.equal(shouldAutoScrollExpandedTreeNode("database"), true);
assert.equal(shouldAutoScrollExpandedTreeNode("group-columns"), true);
});
test("expanded sidebar nodes scroll enough to reveal inserted rows", () => {
assert.equal(
scrollTopForExpandedTreeNode({