Commit Graph

203 Commits

Author SHA1 Message Date
Eric Robinson 17c80e4083 Do not autoplay in mobile in `setMusic`
This change appears to have been made to support playlist auto-advance in mobile. This was a workaround to handle the autoplay guard lower in the function which was removed in an earlier commit on this branch. The play call is now handled external to the `setMusic` call, which allows external logic to determine whether play should be called on mobile or not.
2017-12-12 13:40:39 -05:00
Eric Robinson fa66dd90f4 Ensure that automatic playlist advance works
When playlists advance, the music should continue to play. The recent change to stop `setMusic` from "autoplaying" in this case must now be handled directly by the caller. This is far more clear to read: "set next music and play it."
2017-12-12 13:37:31 -05:00
Eric Robinson bd4426ff2b Remove redundant check
The constructor ensures that autoplay is false for mobile devices at this point.
2017-12-12 13:11:12 -05:00
Eric Robinson c0e868484a Move the autoplay check into the constructor
The `autoplay` option only makes sense in the constructor. After that, callers of `setMusic` should determine whether or not to begin playback based on their own state.
2017-12-12 13:09:35 -05:00
Eric Robinson ea7a97af3f
Merge pull request #1 from ericdrobinson/simple-fixes
Simple fixes
2017-12-12 12:47:55 -05:00
Eric Robinson a6705d08b1 Build output for simple fix changes
Built files that incorporate changes from this branch.
2017-12-12 12:41:34 -05:00
Eric Robinson db6e0f8b84 Verify actual state rather than flag
No need to track against a separate (and possibly out-of-sync) flag when it is just as easy to check the actual state of the loaded music.
2017-12-12 12:35:26 -05:00
Eric Robinson 00bec0c66e Remove unnecessary branches in code
Modulo operators are perfect for this type of logic.
2017-12-12 11:55:39 -05:00
DIYgod 275bbfcd07
README: Related Projects & Who use APlayer & Sponsor 2017-11-30 00:29:53 +08:00
DIYgod 62a9e9f1c7
Merge pull request #166 from MPierre9/author-not-showing-fix
Fixes issue #146, Author showing problem
2017-11-24 11:45:59 +08:00
Michael 77d00898be Fixes no author showing bug 2017-11-23 16:55:42 -05:00
DIYgod 67e09f7ab6
Merge pull request #164 from bugkiwi/master
fix aplayer-list listmaxheight bad grammar
2017-11-14 20:16:05 -06:00
gkiwi 00aac89320 Merge branch 'master' of github.com:bugkiwi/APlayer 2017-11-14 19:07:21 +08:00
gkiwi 1fd103c326 修复aplayer-list listmaxheight判断 语法错误问题
Change-Id: I90d1fab602500bcffdac82cb3b19a9b37e636de8
2017-11-14 19:02:17 +08:00
DIYgod 6b252a2c5f
Merge pull request #163 from kn007/patch-1
miss aplayer class
2017-11-02 21:21:44 -05:00
Karl Chen 719c5ce3ea
miss aplayer class 2017-11-02 21:29:50 +08:00
DIYgod f6fdb2a49d
Merge pull request #162 from kn007/patch-1
fix pic 重复打印,拉伸输出
2017-11-01 21:35:59 -05:00
DIYgod af85763598
Merge pull request #161 from kn007/patch-1
fix pic 继承问题
2017-11-01 02:38:47 -05:00
Karl Chen 665b0e7342
Update APlayer.scss 2017-10-31 23:00:16 +08:00
Karl Chen ceb2bc5feb
Update APlayer.js 2017-10-31 12:10:36 +08:00
DIYgod 6c019aba08 Merge pull request #158 from liwanglin12/patch-1
🐛 Fix Typo #157
2017-10-13 07:16:06 -05:00
liwanglin12 bce02f0016 🐛 Fix Typo #157 2017-10-13 19:46:34 +08:00
DIYgod 021eb283a3
update README 2017-09-23 21:18:01 +08:00
DIYgod e41fa9901d
add Who use APlayer 2017-09-07 10:40:46 +08:00
DIYgod f25e0bf82d
new `Who use APlayer`: iSearch 2017-08-22 00:31:46 +08:00
DIYgod b88341b233
README: add APlayer-Controler 2017-08-15 15:17:07 +08:00
DIYgod 8d690b81df
update README: Media formats 2017-08-09 15:39:56 +08:00
DIYgod 1ed95f0045
update README: fix links; add `Who use APlayer` 2017-08-09 15:35:56 +08:00
DIYgod ebd8a48aca
add `Related Projects` 2017-07-26 02:24:15 +08:00
DIYgod c8e912788b
update README and LICENSE 2017-07-23 23:19:25 +08:00
DIYgod dedcfbf1ac
switch to next song in mobile, close #138 2017-06-08 00:16:56 +08:00
DIYgod f0927af30b
add `php-aplayer` to Related Projects 2017-05-18 11:35:38 +08:00
DIYgod c6e4085a65
update README 2017-04-21 00:36:26 +08:00
Wenjie Fan 8d6f2327b9 Merge pull request #130 from remyabel/master
Wrap getSVG calls in template literal syntax
2017-04-01 00:03:36 +08:00
Tommy Nguyen 9a99a327e3 Wrap getSVG calls in template literal syntax 2017-03-31 11:56:06 -04:00
DIYgod 9f0a9aecbc
better demo page 2017-03-27 11:05:38 +08:00
DIYgod cbc0f99eee new api: destroy, addMusic 2017-03-26 23:31:22 +08:00
DIYgod c3d98f3aca
update devDependencies 2017-03-10 18:39:51 +08:00
DIYgod bf566955a8
add CDN unpkg 2017-03-08 19:00:19 +08:00
DIYgod 960b8b34fd
add ISSUE_TEMPLATE 2017-03-08 18:50:13 +08:00
DIYgod d381582fe4
prevent buttons from submitting forms 2017-02-09 11:22:58 +08:00
DIYgod 3d64d42305
upgrade node version in travis-ci 2017-02-06 12:27:15 +08:00
DIYgod 7b4d2320a8
use yarn, upgrade to webpack2 2017-02-06 12:12:25 +08:00
DIYgod 6f2174cab4
update README: npm script 2017-01-19 18:21:18 +08:00
DIYgod ef1ae2b761
optimize webpack workflow 2017-01-19 18:18:04 +08:00
Wenjie Fan 6f496ac41c Merge pull request #112 from zanseven007/master
update copyright
2016-12-30 18:48:59 +08:00
Zanyuyu 287950513d update copyright
update copyright for 2017
2016-12-30 18:42:22 +08:00
DIYgod 584f11ce04
update dev-devdependencies 2016-12-22 00:20:04 +08:00
DIYgod 53096c4e0b
unify `ap.play()` with `ap.audio.play()`, close #98 2016-12-22 00:14:12 +08:00
DIYgod c4c3ead825
fix NaN before canplay, close #94 2016-12-21 18:48:02 +08:00