chore: fix more warnings (#418)

This commit is contained in:
egolearner
2026-05-21 11:15:41 +08:00
committed by GitHub
parent 51c6d9e0ec
commit 9bfc4b556a
24 changed files with 81 additions and 59 deletions
@@ -158,10 +158,10 @@ class FlatSparseStreamer : public IndexStreamer {
enum State { STATE_INIT = 0, STATE_INITED = 1, STATE_OPENED = 2 };
IndexMeta meta_{};
Stats stats_{};
FlatSparseStreamerEntity entity_;
uint32_t magic_{0U};
Stats stats_{};
State state_{STATE_INIT};
//! avoid add vector while dumping index
+1 -1
View File
@@ -102,7 +102,7 @@ int HnswContext::update(const ailego::Params &params) {
}
if (params.has(p)) {
bool bf_enabled;
bool bf_enabled = false;
params.get(p, &bf_enabled);
if (bf_enabled ^ (filter_mode_ == VisitFilter::BloomFilter)) {
need_update = true;
@@ -103,7 +103,7 @@ int HnswRabitqContext::update(const ailego::Params &params) {
}
if (params.has(p)) {
bool bf_enabled;
bool bf_enabled = false;
params.get(p, &bf_enabled);
if (bf_enabled ^ (filter_mode_ == VisitFilter::BloomFilter)) {
need_update = true;
@@ -196,6 +196,7 @@ class HnswRabitqStreamer : public IndexStreamer {
}
};
Stats stats_{};
HnswRabitqStreamerEntity entity_;
HnswRabitqAlgorithm::UPointer alg_;
IndexMeta meta_{};
@@ -211,8 +212,6 @@ class HnswRabitqStreamer : public IndexStreamer {
HnswRabitqQueryAlgorithm::UPointer query_alg_; // query algorithm
// provider_ provides raw vector, which is used to build graph
IndexProvider::Pointer provider_{};
Stats stats_{};
std::mutex mutex_{};
size_t max_index_size_{0UL};
@@ -98,7 +98,7 @@ int HnswSparseContext::update(const ailego::Params &params) {
}
if (params.has(p)) {
bool bf_enabled;
bool bf_enabled = false;
params.get(p, &bf_enabled);
if (bf_enabled ^ (filter_mode_ == VisitFilter::BloomFilter)) {
need_update = true;
@@ -176,6 +176,7 @@ class HnswSparseStreamer : public IndexStreamer {
}
};
Stats stats_{};
HnswSparseStreamerEntity entity_;
HnswSparseAlgorithm::UPointer alg_;
IndexMeta meta_{};
@@ -183,7 +184,6 @@ class HnswSparseStreamer : public IndexStreamer {
IndexMetric::MatrixSparseDistance add_distance_{};
IndexMetric::MatrixSparseDistance search_distance_{};
Stats stats_{};
std::mutex mutex_{};
size_t max_index_size_{0UL};
+13 -11
View File
@@ -218,19 +218,20 @@ class VamanaEntity {
std::vector<IndexStorage::MemoryBlock> &vec_blocks) const = 0;
virtual const Neighbors get_neighbors(node_id_t id) const = 0;
virtual int add_vector(key_t key, const void *vec, node_id_t *id) {
virtual int add_vector(key_t /*key*/, const void * /*vec*/,
node_id_t * /*id*/) {
return IndexError_NotImplemented;
}
virtual int add_vector_with_id(node_id_t id, const void *vec) {
virtual int add_vector_with_id(node_id_t /*id*/, const void * /*vec*/) {
return IndexError_NotImplemented;
}
virtual int update_neighbors(
node_id_t id,
const std::vector<std::pair<node_id_t, dist_t>> &neighbors) {
node_id_t /*id*/,
const std::vector<std::pair<node_id_t, dist_t>> & /*neighbors*/) {
return IndexError_NotImplemented;
}
virtual void add_neighbor(node_id_t id, uint32_t size,
node_id_t neighbor_id) {}
virtual void add_neighbor(node_id_t /*id*/, uint32_t /*size*/,
node_id_t /*neighbor_id*/) {}
// --- Neighbor distance storage (CSR-like, lazy-loaded) ---
// Each node has max_degree dist_t slots, the i-th slot stores the distance
@@ -250,19 +251,20 @@ class VamanaEntity {
// Get pointer to the distance array for node `id`.
// Returns nullptr if dist storage is not loaded.
virtual const dist_t *get_neighbor_dists(node_id_t id) const {
virtual const dist_t *get_neighbor_dists(node_id_t /*id*/) const {
return nullptr;
}
// Update all neighbor distances for node `id` from a prune result.
virtual void update_neighbor_dists(
node_id_t id,
const std::vector<std::pair<node_id_t, dist_t>> &neighbors) {}
node_id_t /*id*/,
const std::vector<std::pair<node_id_t, dist_t>> & /*neighbors*/) {}
// Set the distance for the `idx`-th neighbor of node `id`.
virtual void set_neighbor_dist(node_id_t id, uint32_t idx, dist_t dist) {}
virtual void set_neighbor_dist(node_id_t /*id*/, uint32_t /*idx*/,
dist_t /*dist*/) {}
virtual int dump(const IndexDumper::Pointer &dumper) {
virtual int dump(const IndexDumper::Pointer & /*dumper*/) {
return IndexError_NotImplemented;
}
@@ -173,7 +173,6 @@ class VamanaStreamer : public IndexStreamer {
size_t bruteforce_threshold_{VamanaEntity::kDefaultBruteForceThreshold};
size_t max_scan_limit_{VamanaEntity::kDefaultMaxScanLimit};
size_t min_scan_limit_{VamanaEntity::kDefaultMinScanLimit};
float bf_negative_prob_{VamanaEntity::kDefaultBFNegativeProbability};
float max_scan_ratio_{VamanaEntity::kDefaultScanRatio};
uint32_t magic_{0U};
@@ -175,8 +175,8 @@ class VamanaStreamerEntity : public VamanaEntity {
use_key_info_map_(use_key_info_map),
keys_map_lock_(keys_map_lock),
keys_map_(keys_map),
node_chunks_(std::move(node_chunks)),
broker_(broker) {
broker_(broker),
node_chunks_(std::move(node_chunks)) {
*mutable_header() = hd;
neighbor_size_ = neighbors_size();
}