From c5dafe9d87e3be0100bc4d72314d78283abea38a Mon Sep 17 00:00:00 2001 From: DIYgod Date: Wed, 8 Feb 2023 17:46:40 +0000 Subject: [PATCH] fix: undefined notification url path --- src/lib/url-composer.ts | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/lib/url-composer.ts b/src/lib/url-composer.ts index ffff3a13..42b8850f 100644 --- a/src/lib/url-composer.ts +++ b/src/lib/url-composer.ts @@ -13,19 +13,26 @@ export const urlComposer: Partial = { } if (originalNote.metadata?.content?.sources?.includes("xlog")) { - const { character } = originalNote - - if (character) { + if (originalNote.metadata?.content?.external_urls?.[0]) { return ( - getSiteLink({ - subdomain: character.handle, - }) + - "/" + - getNoteSlug(originalNote) + + originalNote.metadata.content.external_urls[0] + (originalNote !== note ? `#comments` : "") ) } else { - return "" + const { character } = originalNote + + if (character) { + return ( + getSiteLink({ + subdomain: character.handle, + }) + + "/" + + getNoteSlug(originalNote) + + (originalNote !== note ? `#comments` : "") + ) + } else { + return "" + } } } else { return `${CSB_IO}/notes/${note.characterId}-${note.noteId}`