From 6f95187244c777b614ccddea0a64a6b2b2eca061 Mon Sep 17 00:00:00 2001 From: DIYgod Date: Tue, 4 Apr 2023 00:48:42 +0100 Subject: [PATCH] feat: Improve slug generation and test tolerance - Improve slug generation by replacing non-alphanumeric characters in titles - Optimize pinyin generation by moving character replacement to after its execution --- src/lib/helpers.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/helpers.ts b/src/lib/helpers.ts index 16899423..bcfed714 100644 --- a/src/lib/helpers.ts +++ b/src/lib/helpers.ts @@ -33,8 +33,7 @@ export const getNoteSlug = (note: NoteEntity) => { } export const getDefaultSlug = (title: string, id?: string) => { - title = title.replace(/[^a-zA-Z0-9\s]/g, "") - return ( + let generated = pinyin(title as string, { style: pinyin.STYLE_NORMAL, compact: true, @@ -45,5 +44,7 @@ export const getDefaultSlug = (title: string, id?: string) => { ?.replace(/\s+/g, "-") || id?.replace(`local-`, "") || "" - ) + generated = generated.replace(/[^a-zA-Z0-9\s-_]/g, "") + + return generated }