Files
planning-with-files/scripts/attest-plan.sh
T
OthmanAdi 3e35f428f3 release: v2.40.0 (slug-mode resolution fix + perf cache + KV-cache hygiene + Pi false-positive fix)
Bug fixes (items 1-5 in proposal_v2_40.md):

1. Hook resolution order inverted across UserPromptSubmit, PreToolUse, PreCompact.
   Slug-mode now wins over legacy root task_plan.md when both exist. Closes the
   bug where an active .planning/<slug>/ plan was silently bypassed in favor of
   the root file. Resolution chain: PLAN_ID env > .planning/.active_plan >
   newest .planning/<slug>/ by mtime > root fallback.

2. .active_plan target dir is validated. Dead pointers fall through cleanly.

3. .active_plan content is regex-validated as ^[A-Za-z0-9_][A-Za-z0-9._-]*$.
   Whitespace-only and path-traversal corruption fall through instead of
   producing weird path lookups. Tests cover whitespace, ../escape, and
   leading-dot cases.

4. check-complete.sh wires into resolve-plan-dir.sh when no path arg given.
   Restores slug-mode parity for any caller that invokes the script without an
   explicit plan path.

5. Pi extension dangerous-command detection uses word-boundary regex. Benign
   git push origin <branch> no longer triggers the warning; only --force,
   --mirror, +ref, plus rm -rf, sudo, chmod 777/a+rwx, git reset --hard, git
   clean -fd, fork bombs, dd to /dev/[sh]d[a-z].

Performance (items 6, 7):

6. mtime-keyed SHA-256 cache under ${TMPDIR:-/tmp}/pwf-sha cuts redundant hash
   work on warm cache. Caches the result keyed by absolute plan-file path,
   stores mtime + hash, skips sha256sum when mtime unchanged.

7. KV-cache hygiene on injected progress.md tail. Sub-second timestamps and
   timezone-suffix forms are normalized to a stable epoch-zero form so the
   model's prefix cache stays warm across turns. Manus-aligned.

Portability + races (items 19, 20):

19. resolve-plan-dir.sh portable mtime fallback chain: GNU stat -> BSD stat ->
    date -r -> python3 -> python -> perl -> 0. Multi-plan workflows stop
    silently degrading on non-GNU systems.

20. attest-plan.sh uses atomic temp+rename with optional flock guard.
    Concurrent legacy-mode attestations stop producing truncated files that
    triggered false [PLAN TAMPERED] warnings.

Tests: 130 pass / 2 pre-existing Windows exec-bit failures unchanged. +20 new
tests vs v2.39.0. See CHANGELOG for full inventory.

Version bumped to 2.40.0 across 14 SKILL.md variants + plugin.json +
marketplace.json + CITATION.cff via scripts/bump-version.py. .continue,
.gemini, .pi, .kiro lag intentionally.
2026-05-21 23:07:55 +02:00

172 lines
6.3 KiB
Bash

#!/bin/sh
# planning-with-files: lock the current task_plan.md content with a SHA-256 attestation.
#
# Use after you finalise (or intentionally edit) a plan. The hooks then refuse
# to inject plan content into the model context if the file diverges from the
# attested hash, surfacing a "[PLAN TAMPERED]" warning instead.
#
# Resolution:
# 1. $PLAN_ID env var → ./.planning/$PLAN_ID/
# 2. ./.planning/.active_plan
# 3. Newest ./.planning/<dir>/ by mtime
# 4. Legacy ./task_plan.md at project root
#
# Usage:
# sh scripts/attest-plan.sh # attest the active plan
# sh scripts/attest-plan.sh --show # print the stored hash
# sh scripts/attest-plan.sh --clear # remove the attestation (re-open the plan)
set -u
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
RESOLVER="${SCRIPT_DIR}/resolve-plan-dir.sh"
resolve_plan_file() {
plan_dir=""
if [ -f "${RESOLVER}" ]; then
plan_dir="$(sh "${RESOLVER}" 2>/dev/null)"
fi
if [ -n "${plan_dir}" ] && [ -f "${plan_dir}/task_plan.md" ]; then
printf "%s\n" "${plan_dir}/task_plan.md"
return 0
fi
if [ -f "./task_plan.md" ]; then
printf "%s\n" "./task_plan.md"
return 0
fi
return 1
}
attestation_path_for() {
plan_file="$1"
plan_dir="$(dirname "${plan_file}")"
if [ "${plan_dir}" = "." ]; then
# Legacy mode: store at project root.
printf "%s\n" "./.plan-attestation"
else
printf "%s\n" "${plan_dir}/.attestation"
fi
}
compute_hash() {
target="$1"
if command -v sha256sum >/dev/null 2>&1; then
sha256sum "${target}" | awk '{print $1}'
elif command -v shasum >/dev/null 2>&1; then
shasum -a 256 "${target}" | awk '{print $1}'
else
printf "ERROR: no sha256 utility available\n" >&2
return 1
fi
}
mode="attest"
case "${1:-}" in
--show) mode="show" ;;
--clear) mode="clear" ;;
"") mode="attest" ;;
*)
printf "Usage: %s [--show|--clear]\n" "$0" >&2
exit 2
;;
esac
plan_file="$(resolve_plan_file)" || {
printf "[plan-attest] No task_plan.md found. Create a plan first.\n" >&2
exit 1
}
attestation_file="$(attestation_path_for "${plan_file}")"
case "${mode}" in
show)
if [ -f "${attestation_file}" ]; then
printf "Plan: %s\n" "${plan_file}"
printf "Attestation: %s\n" "${attestation_file}"
printf "SHA-256: %s\n" "$(cat "${attestation_file}")"
else
printf "[plan-attest] No attestation set for %s.\n" "${plan_file}"
exit 1
fi
;;
clear)
if [ -f "${attestation_file}" ]; then
rm -f "${attestation_file}"
printf "[plan-attest] Cleared attestation for %s.\n" "${plan_file}"
else
printf "[plan-attest] No attestation to clear.\n"
fi
;;
attest)
hash_val="$(compute_hash "${plan_file}")" || exit 1
# v2.40: protect the write with an advisory flock when available so
# concurrent legacy-mode sessions (no PLAN_ID, both at the same project
# root) cannot corrupt the .plan-attestation file mid-write. Atomic
# rename of a temp file is the real guarantee on POSIX; flock is the
# cooperative gate around the rename for slow-disk writes.
#
# Note: legacy single-file mode is inherently racey across concurrent
# sessions because both can edit task_plan.md without coordination. The
# canonical parallel-session pattern is slug-mode under
# .planning/<slug>/, where each session pins PLAN_ID and gets its own
# .attestation file. We surface a hint when concurrent activity is
# detected.
if [ -f "${attestation_file}" ]; then
mtime_now="$(date +%s 2>/dev/null || echo 0)"
mtime_prev="$(stat -c '%Y' "${attestation_file}" 2>/dev/null \
|| stat -f '%m' "${attestation_file}" 2>/dev/null \
|| echo 0)"
age=$((mtime_now - mtime_prev))
if [ "${age}" -ge 0 ] && [ "${age}" -lt 30 ] 2>/dev/null; then
# If we're in legacy mode (root .plan-attestation) and another
# session just wrote, warn. Slug-mode files in .planning/<slug>/
# are per-session by construction; no need to warn there.
case "${attestation_file}" in
*./.plan-attestation|*/.plan-attestation)
case "${attestation_file}" in
*./.planning/*) : ;; # slug-mode, ignore
*)
printf "[plan-attest] Note: %s was modified %ss ago by another process.\n" \
"${attestation_file}" "${age}" >&2
printf "[plan-attest] For parallel sessions, prefer slug-mode (init-session.sh <name>) so each session gets its own .attestation file.\n" >&2
;;
esac
;;
esac
fi
fi
tmp_file="${attestation_file}.tmp.$$"
printf "%s\n" "${hash_val}" > "${tmp_file}" 2>/dev/null || {
printf "[plan-attest] Failed to write %s\n" "${tmp_file}" >&2
exit 1
}
if command -v flock >/dev/null 2>&1; then
# Advisory lock around the rename. lock_dir is the dir containing
# the target file. The {} subshell pattern keeps the lock scoped to
# the mv call.
lock_dir="$(dirname "${attestation_file}")"
(
flock -w 5 9 || true
mv -f "${tmp_file}" "${attestation_file}"
) 9>"${lock_dir}/.attestation.lock" 2>/dev/null
rm -f "${lock_dir}/.attestation.lock" 2>/dev/null
else
mv -f "${tmp_file}" "${attestation_file}" 2>/dev/null
fi
# If mv failed for any reason, fall back to direct write.
if [ ! -f "${attestation_file}" ]; then
printf "%s\n" "${hash_val}" > "${attestation_file}"
fi
short_hash="$(printf "%s" "${hash_val}" | cut -c1-12)"
printf "[plan-attest] Locked %s\n" "${plan_file}"
printf "[plan-attest] SHA-256: %s... (stored in %s)\n" "${short_hash}" "${attestation_file}"
printf "[plan-attest] Hooks will block injection if the file is modified without re-running this command.\n"
;;
esac
exit 0