diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7806c80..23f5b6f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -29,7 +29,9 @@ jobs: # on ubuntu so GNU-only regressions fail there too. os: [ubuntu-latest, windows-latest, macos-latest] runs-on: ${{ matrix.os }} - timeout-minutes: 15 + # Windows runs the full suite through Git Bash and native PowerShell. + # Successful runs already approach 15 minutes; allow runner variance. + timeout-minutes: ${{ matrix.os == 'windows-latest' && 30 || 15 }} steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 @@ -45,7 +47,7 @@ jobs: # sh.exe on windows-latest). run: python -c "import shutil, sys; sys.exit(0 if shutil.which('sh') else 1)" - name: Run pytest - run: python -m pytest tests/ -q + run: python -m pytest tests/ -q --durations=20 vitest: name: vitest (Pi extension) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 99d46cd..f462296 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,7 +32,15 @@ Before opening a pull request, run the test suite: python -m pytest tests/ -q ``` -Two pre-existing Windows exec-bit test failures may appear on Windows. If those are the only failures, note that in your pull request description. +Investigate test failures and include any unresolved findings in your pull request description. + +## CI completion rule + +Maintainer delivery is complete only after all five `Tests` jobs succeed on the final commit pushed to `master`: pytest on Linux, Windows and macOS, plus the Pi extension and OpenCode plugin suites. + +After the final push, verify the remote `master` commit and wait for its workflow to finish. Queued, running, cancelled, timed-out, failed or missing checks mean verification is unfinished. Continue investigating, fixing and rerunning until every job is green. Preserve test coverage and security checks; change runtime limits only when measured runtime justifies a bounded adjustment. + +A passing candidate branch or an identical Git tree does not replace checks on the final pushed commit. Recheck remote `master` and its check results immediately before reporting completion. If the user explicitly stops the work or an external blocker prevents progress, record the unfinished checks and the blocker. ## Project layout