* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
66 lines
2.0 KiB
TypeScript
66 lines
2.0 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
buildLinearWorkspaceSource,
|
|
buildWorkspaceSourceSelection,
|
|
getWorkspaceSourceName,
|
|
getWorkspaceSourceProvider,
|
|
shouldApplyWorkspaceSourceAutoName,
|
|
shouldPreserveWorkspaceSourceOnRepoChange
|
|
} from './workspace-source'
|
|
|
|
describe('workspace source policy', () => {
|
|
const linear = buildLinearWorkspaceSource({
|
|
identifier: 'ENG-42',
|
|
title: 'Ship mobile parity',
|
|
url: 'https://linear.app/acme/issue/ENG-42/ship-mobile-parity',
|
|
workspaceId: 'workspace-1'
|
|
})
|
|
|
|
it('builds one Linear identity for desktop and mobile create flows', () => {
|
|
expect(linear).toMatchObject({
|
|
provider: 'linear',
|
|
number: 0,
|
|
linearIdentifier: 'ENG-42',
|
|
linearWorkspaceId: 'workspace-1',
|
|
linearOrganizationUrlKey: 'acme'
|
|
})
|
|
expect(getWorkspaceSourceName(linear)).toEqual({
|
|
seedName: 'eng-42-ship-mobile-parity',
|
|
displayName: 'ENG-42 Ship mobile parity'
|
|
})
|
|
})
|
|
|
|
it('preserves global work-item sources across repo changes', () => {
|
|
expect(shouldPreserveWorkspaceSourceOnRepoChange(linear)).toBe(true)
|
|
expect(
|
|
shouldPreserveWorkspaceSourceOnRepoChange({
|
|
provider: 'github',
|
|
type: 'issue',
|
|
number: 1,
|
|
title: 'Repo scoped',
|
|
url: 'https://github.com/o/r/issues/1'
|
|
})
|
|
).toBe(false)
|
|
})
|
|
|
|
it('shares provider inference, selection labels, and auto-name gates', () => {
|
|
const legacyGitLab = {
|
|
type: 'issue' as const,
|
|
number: 7,
|
|
title: 'Self hosted',
|
|
url: 'https://gitlab.example.com/g/p/-/work_items/7'
|
|
}
|
|
expect(getWorkspaceSourceProvider(legacyGitLab)).toBe('gitlab')
|
|
expect(buildWorkspaceSourceSelection({ linkedWorkItem: legacyGitLab })).toMatchObject({
|
|
kind: 'gitlab-issue',
|
|
label: '#7 Self hosted'
|
|
})
|
|
expect(shouldApplyWorkspaceSourceAutoName({ currentName: '#42', lastAutoName: 'old' })).toBe(
|
|
true
|
|
)
|
|
expect(
|
|
shouldApplyWorkspaceSourceAutoName({ currentName: 'my workspace', lastAutoName: 'old' })
|
|
).toBe(false)
|
|
})
|
|
})
|