orca/.github
Neil 17cfc968cf
Revert the terminal IME composition-ownership change (#13282)
* Revert "test(ime): restore coverage the composition-ownership change removed (#13168)"

This reverts commit 25a8c517e1.

* Revert "refactor(terminal): return IME composition ownership to xterm (#13128)"

This reverts commit 17b3dff3c4.

* test(ime): keep the architecture-neutral Korean trace coverage

The recorded IBus/fcitx5 and Windows MS-Korean traces from #13168 assert PTY
byte order, not composition ownership, so they still hold once the terminal
composition layer is restored. The mobile accessory-order test pinned the new
handleLiveInputChange signature and does not.

Co-authored-by: Orca <help@stably.ai>

* fix(terminal): keep the macOS Backslash bypass through the revert

The restored native-text forwarder only claims keys for input sources in its
hardcoded CJK allowlist, so third-party IMEs off that list (Qingg, #10896) still
get a raw backslash. #13128 added this bypass as a partial replacement; keep it
rather than trade the open issue back.

Scoped to the bare backslash key. The rest of shouldBypassXtermForMacNativeText
bypassed all unmodified non-ASCII text, which would race the restored forwarder.

Co-authored-by: Orca <help@stably.ai>

* fix(mobile): move the mirror-step ref write out of render

The restored hook assigned runMirrorStepRef during render, which is not
replay-safe — React can discard render work, so the mutation can leak from UI
that never commits. Its only read is inside the held-commit timer, which fires
long after commit, and the ref has a safe default, so an effect is soon enough.

Surfaced by the changed-lines React Doctor gate: the rule postdates this code,
so restoring the file re-introduced it as a new violation.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-08-08 19:06:50 -07:00
..
ISSUE_TEMPLATE chore: ask issue reporters to write in English (#12066) 2026-08-01 23:28:10 -07:00
actions fix(release): survive PSGallery outages in the Windows signing preflight 2026-07-30 18:16:38 -07:00
scripts ci: block new root-level entries (#11903) 2026-08-01 01:48:24 -07:00
workflows Revert the terminal IME composition-ownership change (#13282) 2026-08-08 19:06:50 -07:00
CODEOWNERS chore: declutter top-level repo layout (#11890) 2026-08-01 00:25:35 -07:00
CONTRIBUTING.md Update CONTRIBUTING.md 2026-06-01 23:38:15 -07:00
pull_request_template.md docs: add contribution guide and PR template (#163) 2026-03-28 10:44:02 -07:00