* fix(gh-project): diagnose env-shadowed gh tokens in auth errors `gh auth refresh -s project` silently no-ops when GITHUB_TOKEN/GH_TOKEN is exported in the user's shell — gh prefers env tokens and refuses to modify them, exiting 0. Users follow the canned remediation, see no error, retry, and stay stuck. Add a one-shot `gh auth status` probe (gh:diagnoseAuth IPC) that: - Detects env-shadowed credentials and rewrites the fix to `unset GITHUB_TOKEN` plus a grep to find where it's exported. - Detects missing gh install, plain missing-scope on a keyring login, and SAML SSO authorization. - Surfaces a tailored multi-button error UI in ProjectViewWrapper and ProjectPicker instead of one canned 'Copy command'. Co-authored-by: Orca <help@stably.ai> * fix(gh-project): address review feedback - Cross-platform shell guidance: PowerShell commands on Windows (Get-ChildItem Env:, Remove-Item Env:, [Environment]::SetEnvironmentVariable) via navigator.userAgent platform check. - Use `window.api.shell.openUrl` for the docs button instead of `window.open`, matching SidebarToolbar's external-URL pattern. - Tighten gh auth status parser: accept single-label hostnames and optional trailing colon; recover host from the inline 'Logged in to <host>' line so a missed section header never silently drops accounts. - Add tests for multi-host output and host-recovery fallback. - Drop dead command/copy locals in ProjectViewWrapper.ErrorState by short-circuiting the auth-error case before they're computed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
98 lines
3.2 KiB
TypeScript
98 lines
3.2 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { parseAuthStatus } from './auth-diagnose'
|
|
|
|
describe('parseAuthStatus', () => {
|
|
it('parses an env-shadowed login alongside a keyring login (real gh output)', () => {
|
|
const text = `github.com
|
|
✓ Logged in to github.com account nwparker (GITHUB_TOKEN)
|
|
- Active account: true
|
|
- Git operations protocol: https
|
|
- Token: gho_************************************
|
|
- Token scopes: 'gist', 'read:org', 'repo', 'workflow'
|
|
|
|
✓ Logged in to github.com account nwparker (keyring)
|
|
- Active account: false
|
|
- Git operations protocol: https
|
|
- Token: gho_************************************
|
|
- Token scopes: 'gist', 'read:org', 'repo', 'workflow'
|
|
`
|
|
const accounts = parseAuthStatus(text)
|
|
expect(accounts).toHaveLength(2)
|
|
expect(accounts[0]).toMatchObject({
|
|
host: 'github.com',
|
|
user: 'nwparker',
|
|
active: true,
|
|
envToken: 'GITHUB_TOKEN',
|
|
source: 'env'
|
|
})
|
|
expect(accounts[0].scopes).toEqual(['gist', 'read:org', 'repo', 'workflow'])
|
|
expect(accounts[1]).toMatchObject({
|
|
active: false,
|
|
envToken: null,
|
|
source: 'keyring'
|
|
})
|
|
})
|
|
|
|
it('parses a single keyring login', () => {
|
|
const text = `github.com
|
|
✓ Logged in to github.com account alice (keyring)
|
|
- Active account: true
|
|
- Token scopes: 'project', 'read:org', 'repo'
|
|
`
|
|
const accounts = parseAuthStatus(text)
|
|
expect(accounts).toHaveLength(1)
|
|
expect(accounts[0]).toMatchObject({
|
|
user: 'alice',
|
|
active: true,
|
|
envToken: null,
|
|
source: 'keyring'
|
|
})
|
|
expect(accounts[0].scopes).toContain('project')
|
|
})
|
|
|
|
it('detects GH_TOKEN env source', () => {
|
|
const text = `github.com
|
|
✓ Logged in to github.com account bot (GH_TOKEN)
|
|
- Active account: true
|
|
- Token scopes: 'repo'
|
|
`
|
|
const [acc] = parseAuthStatus(text)
|
|
expect(acc.envToken).toBe('GH_TOKEN')
|
|
expect(acc.source).toBe('env')
|
|
})
|
|
|
|
it('returns empty array when nothing is logged in', () => {
|
|
expect(parseAuthStatus('You are not logged into any GitHub hosts.')).toEqual([])
|
|
})
|
|
|
|
it('parses multiple hosts in one output (github.com + GHES)', () => {
|
|
const text = `github.com
|
|
✓ Logged in to github.com account alice (keyring)
|
|
- Active account: true
|
|
- Token scopes: 'read:org', 'repo'
|
|
|
|
ghe.acme.io
|
|
✓ Logged in to ghe.acme.io account bob (keyring)
|
|
- Active account: true
|
|
- Token scopes: 'project', 'repo'
|
|
`
|
|
const accounts = parseAuthStatus(text)
|
|
expect(accounts.map((a) => a.host)).toEqual(['github.com', 'ghe.acme.io'])
|
|
expect(accounts.map((a) => a.user)).toEqual(['alice', 'bob'])
|
|
expect(accounts[1].scopes).toContain('project')
|
|
})
|
|
|
|
it('recovers host from the Logged-in line when the section header is missing', () => {
|
|
// gh prints a colon after the host on some versions; we tolerate it,
|
|
// but if the regex ever fails to match the header we still want
|
|
// accounts attributed to the host from the inline message.
|
|
const text = ` ✓ Logged in to github.acme.io account carol (keyring)
|
|
- Active account: true
|
|
- Token scopes: 'project'
|
|
`
|
|
const accounts = parseAuthStatus(text)
|
|
expect(accounts).toHaveLength(1)
|
|
expect(accounts[0].host).toBe('github.acme.io')
|
|
})
|
|
})
|