* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
83 lines
2.7 KiB
TypeScript
83 lines
2.7 KiB
TypeScript
import { readFile } from 'node:fs/promises'
|
|
import { join } from 'node:path'
|
|
import type { HostedReviewProvider } from '../../shared/hosted-review'
|
|
import { getSshFilesystemProvider } from '../providers/ssh-filesystem-dispatch'
|
|
import { joinWorktreeRelativePath } from '../runtime/runtime-relative-paths'
|
|
|
|
const PULL_REQUEST_TEMPLATE_CANDIDATES = [
|
|
'.github/pull_request_template.md',
|
|
'.github/PULL_REQUEST_TEMPLATE.md',
|
|
'.azuredevops/pull_request_template.md',
|
|
'.azuredevops/PULL_REQUEST_TEMPLATE.md',
|
|
'.gitea/pull_request_template.md',
|
|
'.gitea/PULL_REQUEST_TEMPLATE.md',
|
|
'pull_request_template.md',
|
|
'PULL_REQUEST_TEMPLATE.md',
|
|
'docs/pull_request_template.md',
|
|
'docs/PULL_REQUEST_TEMPLATE.md'
|
|
]
|
|
|
|
const MERGE_REQUEST_TEMPLATE_CANDIDATES = [
|
|
'.gitlab/merge_request_templates/Default.md',
|
|
'.gitlab/merge_request_templates/default.md',
|
|
'.gitlab/merge_request_template.md',
|
|
'.gitlab/MERGE_REQUEST_TEMPLATE.md'
|
|
]
|
|
|
|
function getTemplateCandidates(provider?: HostedReviewProvider | null): string[] {
|
|
if (provider === 'gitlab') {
|
|
return [...MERGE_REQUEST_TEMPLATE_CANDIDATES, ...PULL_REQUEST_TEMPLATE_CANDIDATES]
|
|
}
|
|
return PULL_REQUEST_TEMPLATE_CANDIDATES
|
|
}
|
|
|
|
export async function readHostedPullRequestTemplate(
|
|
repoPath: string,
|
|
connectionId?: string | null
|
|
): Promise<string> {
|
|
return readHostedReviewTemplate(repoPath, connectionId)
|
|
}
|
|
|
|
export async function readHostedReviewTemplate(
|
|
repoPath: string,
|
|
connectionId?: string | null,
|
|
provider?: HostedReviewProvider | null
|
|
): Promise<string> {
|
|
const remoteProvider = connectionId ? getSshFilesystemProvider(connectionId) : undefined
|
|
if (connectionId && !remoteProvider) {
|
|
return ''
|
|
}
|
|
for (const relativeCandidate of getTemplateCandidates(provider)) {
|
|
try {
|
|
if (remoteProvider) {
|
|
const result = await remoteProvider.readFile(
|
|
joinWorktreeRelativePath(repoPath, relativeCandidate)
|
|
)
|
|
if (result.isBinary) {
|
|
continue
|
|
}
|
|
return result.content
|
|
}
|
|
return await readFile(join(repoPath, relativeCandidate), 'utf8')
|
|
} catch {
|
|
// Try the next conventional hosted-review template path.
|
|
}
|
|
}
|
|
return ''
|
|
}
|
|
|
|
export async function resolveHostedReviewBodyForGeneration(args: {
|
|
body: string
|
|
repoPath: string
|
|
connectionId?: string | null
|
|
provider?: HostedReviewProvider | null
|
|
useTemplate?: boolean
|
|
}): Promise<string> {
|
|
if (!args.useTemplate || args.body.trim()) {
|
|
return args.body
|
|
}
|
|
// Why: generated non-empty bodies bypass provider-side template fallback, so
|
|
// preload the template into the AI context when the user asked to use it.
|
|
return readHostedReviewTemplate(args.repoPath, args.connectionId, args.provider)
|
|
}
|