orca/.github
Brennan Benson 59a7fffcd6
fix(terminal): keep WebGL glyph atlas pages within the shader sampler budget (#8672)
* fix(terminal): keep WebGL glyph atlas pages within the shader sampler budget

The fragment shader has sampler slots for maxAtlasPages (16 on most Macs)
and leaves outColor uninitialized for any higher page index, so glyphs
rasterized onto pages past the budget render as garbled pixels. Long
sessions grow past the budget via the merge fallback, and the previous
wipe fix re-activated those unbindable pages, so every atlas wipe
re-allocated glyphs onto them (post-wipe allocation prefers the last,
highest-index active page) and garbled whole panes mid-stream.

Fix, matching the direction xterm.js maintainers are pursuing upstream
(xtermjs/xterm.js#6043): a shared _evictAllPages resets the atlas to one
fresh page, called from clearTexture and from the two allocation paths
that could otherwise push a page past the budget (merge fallback and
oversized-glyph page creation), so the page count can never exceed the
renderer's texture capacity. Defensive backstops: a one-time warn plus
bind-loop clamp, and an else branch in the generated shader so an
unexpected overflow renders blank instead of undefined pixels.

* test(terminal): cover WebGL atlas sampler budget

* fix(terminal): align WebGL atlas invalidation source
2026-07-14 14:48:21 -07:00
..
ISSUE_TEMPLATE Assign GitHub issue types (Bug/Feature) via issue templates (#8346) 2026-07-11 20:20:49 -07:00
scripts Use generated README downloads badge 2026-06-16 11:09:40 -07:00
workflows fix(terminal): keep WebGL glyph atlas pages within the shader sampler budget (#8672) 2026-07-14 14:48:21 -07:00
CONTRIBUTING.md Update CONTRIBUTING.md 2026-06-01 23:38:15 -07:00
pull_request_template.md docs: add contribution guide and PR template (#163) 2026-03-28 10:44:02 -07:00