Files
orca/src/main/emulator/simctl-simulator-devices.test.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

97 lines
2.7 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest'
import type * as Os from 'node:os'
const { execFileMock, platformMock } = vi.hoisted(() => ({
execFileMock: vi.fn(),
platformMock: vi.fn(() => 'darwin')
}))
vi.mock('child_process', () => ({
execFile: execFileMock
}))
vi.mock('os', async (importOriginal) => {
const actual = await importOriginal<typeof Os>()
return {
...actual,
platform: platformMock
}
})
vi.mock('./serve-sim-execution', () => ({
execServeSimCommand: vi.fn()
}))
import { listSimulatorDevices } from './simctl-simulator-devices'
describe('listSimulatorDevices', () => {
beforeEach(() => {
execFileMock.mockReset()
platformMock.mockReset()
platformMock.mockReturnValue('darwin')
})
it('parses simctl devices on macOS', async () => {
execFileMock.mockImplementation((_command, _args, _options, callback) => {
callback(
null,
JSON.stringify({
devices: {
'com.apple.CoreSimulator.SimRuntime.iOS-18-0': [
{
name: 'iPhone 17 Pro',
udid: 'AAAAAAAA-BBBB-CCCC-DDDD-EEEEEEEEEEEE',
state: 'Shutdown',
isAvailable: true
}
]
}
}),
''
)
})
await expect(listSimulatorDevices()).resolves.toEqual([
{
name: 'iPhone 17 Pro',
udid: 'AAAAAAAA-BBBB-CCCC-DDDD-EEEEEEEEEEEE',
state: 'Shutdown',
runtime: 'com.apple.CoreSimulator.SimRuntime.iOS-18-0',
isAvailable: true
}
])
expect(execFileMock).toHaveBeenCalledWith(
'xcrun',
['simctl', 'list', 'devices', '-j'],
{ timeout: 15_000 },
expect.any(Function)
)
})
it('returns no devices on non-macOS hosts', async () => {
platformMock.mockReturnValue('linux')
await expect(listSimulatorDevices()).resolves.toEqual([])
expect(execFileMock).not.toHaveBeenCalled()
})
it('normalizes missing simctl errors for UI and CLI callers', async () => {
execFileMock.mockImplementation((_command, _args, _options, callback) => {
callback(
Object.assign(new Error('Command failed: xcrun simctl list devices -j'), { code: 72 }),
'',
'xcrun: error: unable to find utility "simctl", not a developer tool or in PATH'
)
})
const error = await listSimulatorDevices().catch((caught: unknown) => caught)
expect(error).toMatchObject({
code: 'emulator_simctl_unavailable',
message: expect.stringContaining('Xcode Simulator tools are unavailable')
})
expect(error).toBeInstanceOf(Error)
expect((error as Error).message).not.toContain('Command failed')
})
})