orca/mobile/app
Neil 6e7ceafd07
perf(mobile): avoid unchanged worktree catalog payloads (#11735)
* perf(mobile): avoid unchanged worktree catalog payloads

* fix(mobile): isolate catalog snapshots by limit

* review: reassert host truth on unchanged polls; content-address snapshots

Client — the `changed` gate meant an unchanged poll skipped setWorktrees /
setLastKnownWorktrees / setCachedWorktrees, so optimistic local edits
(togglePin, handleDeleteWorktree's failure re-add) and the #8498 cache guard
were no longer repaired while the host catalog was stable. The gate bought
nothing: setCachedWorktrees is an in-memory Map write and areWorktreeListsEqual
already ran every poll, so the steady state still short-circuits on array
identity. All wire savings are unaffected. admit() now just returns the
confirmed rows and HostScreen applies them exactly as it did pre-PR.

Also on the client:
- a stale response from a superseded client/host no longer clears the token the
  current client/host just established
- discriminate on `worktrees` rather than on `'unchanged' in response`, so a
  future catalog field named `unchanged` can't reclassify a full response
- useRef over useMemo for the snapshot client; React may discard memoized values
- hoist WORKTREE_PS_FULL_LIMIT so the truncates-at-200 rationale travels with it

Host — replace the per-limit snapshot cache with a content-addressed id (ETag
semantics). Ownership lives in the id, so concurrent clients, differing limits,
and runtime restarts are correct by construction; this drops the LRU, the
eviction policy, the per-runtime WeakMap, and the retention of up to 8 full
catalogs. The remaining cache is a pure memo: because ids derive from content,
dropping or thrashing it costs CPU and nothing else. Keeping the memo also
keeps the measured steady-state cost — hashing every poll instead measured
2.24ms vs 0.75ms for the compare on a 310KB catalog.

Verified: mobile 2784 passed / 3 skipped, src/main/runtime/rpc 1064 passed,
node + mobile typechecks, oxlint, oxfmt, max-lines ratchet.

* fix(runtime): isolate catalog snapshot memo

---------

Co-authored-by: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
2026-07-31 23:12:13 -07:00
..
h perf(mobile): avoid unchanged worktree catalog payloads (#11735) 2026-07-31 23:12:13 -07:00
_layout.tsx Add unified mobile onboarding for session view and notifications (#9478) 2026-07-20 11:11:23 -07:00
about.tsx
browser-settings.tsx fix(mobile): add terminal link routing setting 2026-06-16 17:05:12 -07:00
connection-log.tsx Add Orca Relay desktop and mobile transport (#8536) 2026-07-14 11:47:05 -07:00
index.tsx perf(mobile): avoid unchanged worktree catalog payloads (#11735) 2026-07-31 23:12:13 -07:00
mobile-onboarding.tsx Add unified mobile onboarding for session view and notifications (#9478) 2026-07-20 11:11:23 -07:00
native-chat-settings.tsx rename: rebrand user-facing Native chat to Chat UI (#10036) 2026-07-22 19:14:44 -07:00
notification-opt-in.tsx fix(mobile): restore notification opt-in route compatibility (#9675) 2026-07-20 21:15:39 -07:00
notifications.tsx fix(mobile): harden notification opt-in onboarding (#8792) 2026-07-14 19:20:36 -07:00
pair-confirm.tsx Add unified mobile onboarding for session view and notifications (#9478) 2026-07-20 11:11:23 -07:00
pair-scan.tsx Add unified mobile onboarding for session view and notifications (#9478) 2026-07-20 11:11:23 -07:00
pair.tsx
settings.tsx rename: rebrand user-facing Native chat to Chat UI (#10036) 2026-07-22 19:14:44 -07:00
terminal-settings.tsx Redesign mobile driver overlay layout and clarify action copy (#5647) 2026-06-17 19:21:42 -07:00
troubleshoot.tsx mobile: per-host connection log screen with copy-diagnostics (#7984) 2026-07-09 16:20:07 -07:00
voice-settings.tsx perf(mobile): gate dictation setup progress polling on foreground + single-flight (#9892) 2026-07-22 16:22:01 -07:00