import { readFileSync } from 'node:fs' import { dirname, join, resolve } from 'node:path' import { fileURLToPath } from 'node:url' import { describe, expect, it } from 'vitest' const projectDir = resolve(dirname(fileURLToPath(import.meta.url)), '../..') const skillPath = join(projectDir, 'skills', 'orchestration', 'SKILL.md') function readSkill() { return readFileSync(skillPath, 'utf8') } function getSection(markdown, heading) { const escapedHeading = heading.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') const match = markdown.match(new RegExp(`## ${escapedHeading}\\n([\\s\\S]*?)(?=\\n## |$)`)) expect(match).not.toBeNull() return match?.[1] ?? '' } describe('orchestration skill guidance', () => { it('treats long-running worker waits as liveness checkpoints, not failures', () => { const skill = readSkill() expect(skill).toContain('Treat a `check --wait` timeout or `{count:0}` as a checkpoint') expect(skill).toContain('Do not stop, close, kill, or restart a worker') expect(skill).toContain('keep waiting instead of retrying the task') expect(skill).not.toContain( 'If `check --wait` times out with no `worker_done` or `escalation`, fall back to `terminal wait --for tui-idle`, then `terminal read`.' ) }) it('keeps full handoffs out of dispatch lifecycle and off the active branch base', () => { const skill = readSkill() const fullHandoffs = getSection(skill, 'Full Handoffs') expect(skill).toContain('Full handoff means ownership transfer, not supervised dispatch.') expect(fullHandoffs).toContain( 'Do not run `orca orchestration task-create`, `orca orchestration dispatch --inject`, or `orca orchestration check --wait` for full handoffs.' ) expect(fullHandoffs).toContain( '`task-create` is also forbidden because it records coordinator-owned tracking state' ) expect(fullHandoffs).toContain('Do not create a `taskId`/`dispatchId`') expect(fullHandoffs).toContain( 'read the worker terminal after prompt delivery except to avoid losing the initial prompt' ) expect(skill).toContain( '`--no-parent` only controls Orca lineage; it does not choose the Git base.' ) expect(skill).toContain( 'never base it on the current feature branch unless the user explicitly asks' ) expect(skill).toContain( 'orca worktree create --name --no-parent --agent codex --prompt' ) }) it('classifies handoff wording as ownership transfer unless supervision is explicit', () => { const skill = readSkill() const fullHandoffs = getSection(skill, 'Full Handoffs') for (const phrase of [ 'hand off', 'handoff', 'handover', 'give this to another agent', 'give this to another worktree', 'another agent', 'another worktree' ]) { expect(fullHandoffs).toContain(phrase) } for (const supervisionPhrase of [ 'supervise', 'monitor', 'wait for worker_done', 'wait for results', 'track completion', 'DAG', 'decision gate', 'ask/reply' ]) { expect(fullHandoffs).toContain(supervisionPhrase) } }) it('documents custom model and effort handoffs without completion monitoring', () => { const skill = readSkill() const fullHandoffs = getSection(skill, 'Full Handoffs') expect(fullHandoffs).toContain('Custom Codex model/effort handoff') expect(fullHandoffs).toContain( 'does not accept Codex-specific `--model` or `-c model_reasoning_effort=...` arguments' ) expect(fullHandoffs).toContain('codex --model gpt-5.5 -c model_reasoning_effort="xhigh"') expect(fullHandoffs).toContain( 'Wait only for `tui-idle` when needed to avoid losing the prompt.' ) expect(fullHandoffs).toContain('Do not monitor task completion.') }) it('keeps review-only completions and named next-owner fixes in their lanes', () => { const skill = readSkill() expect(skill).toContain( 'A review-only `worker_done` reports findings; it does not authorize coordinator file edits.' ) expect(skill).toContain('unless the user explicitly asked the coordinator to own fixes') expect(skill).toContain('dispatch or hand off fixes') expect(skill).toContain( "If the user's plan names a next owner agent " + '(for example, "then use opencode to create a PR")' ) expect(skill).toContain('post-review corrections and PR prep belong to that named owner') expect(skill).toContain('the named owner edits files and creates the PR') }) })