From bea744b7e4df581dd94d8447ea64e1458b340ca4 Mon Sep 17 00:00:00 2001
From: Neil <4138956+nwparker@users.noreply.github.com>
Date: Sat, 23 May 2026 23:04:59 -0700
Subject: [PATCH] Revert "Hide branch names behind workspace card property"
 (#2740)

---
 src/main/persistence.test.ts                  |  1 -
 .../runtime/rpc/methods/client-ui.test.ts     |  4 +-
 src/main/runtime/rpc/methods/client-ui.ts     |  1 -
 .../sidebar/SidebarWorkspaceOptionsMenu.tsx   |  1 -
 .../WorktreeCard.quick-actions.test.tsx       | 35 ----------------
 .../src/components/sidebar/WorktreeCard.tsx   | 19 ++++-----
 .../WorktreeList.lineage-child-card.test.ts   | 18 ---------
 .../src/components/sidebar/WorktreeList.tsx   | 40 ++++++++-----------
 src/renderer/src/store/slices/ui.test.ts      | 13 ------
 src/shared/constants.test.ts                  | 12 +-----
 src/shared/types.ts                           |  3 --
 src/shared/worktree-card-properties.ts        |  1 -
 12 files changed, 29 insertions(+), 119 deletions(-)

diff --git a/src/main/persistence.test.ts b/src/main/persistence.test.ts
index 9388428b8..f3a1c2fd7 100644
--- a/src/main/persistence.test.ts
+++ b/src/main/persistence.test.ts
@@ -2111,7 +2111,6 @@ describe('Store', () => {
     expect(store.getUI().worktreeCardProperties).toContain('inline-agents')
     expect(store.getUI().worktreeCardProperties).toContain('linear-issue')
     expect(store.getUI().worktreeCardProperties).toContain('ports')
-    expect(store.getUI().worktreeCardProperties).not.toContain('branch')
     expect(store.getUI()._inlineAgentsDefaultedForExperiment).toBe(true)
     expect(store.getUI()._inlineAgentsDefaultedForAllUsers).toBe(true)
     expect(store.getUI()._expandedWorktreeCardPropertiesDefaulted).toBe(true)
diff --git a/src/main/runtime/rpc/methods/client-ui.test.ts b/src/main/runtime/rpc/methods/client-ui.test.ts
index 6cd4892a5..7c591597c 100644
--- a/src/main/runtime/rpc/methods/client-ui.test.ts
+++ b/src/main/runtime/rpc/methods/client-ui.test.ts
@@ -136,7 +136,7 @@ describe('client UI RPC methods', () => {
   it('accepts persisted literal UI arrays and nested UI state', async () => {
     const updated: PersistedUIState = {
       ...getDefaultUIState(),
-      worktreeCardProperties: ['status', 'branch', 'inline-agents'],
+      worktreeCardProperties: ['status', 'inline-agents'],
       statusBarItems: ['codex'],
       taskResumeState: {
         githubMode: 'items',
@@ -163,7 +163,7 @@ describe('client UI RPC methods', () => {
     const dispatcher = new RpcDispatcher({ runtime, methods: CLIENT_UI_METHODS })
 
     const payload = {
-      worktreeCardProperties: ['status', 'branch', 'inline-agents'],
+      worktreeCardProperties: ['status', 'inline-agents'],
       statusBarItems: ['codex'],
       taskResumeState: {
         githubMode: 'items',
diff --git a/src/main/runtime/rpc/methods/client-ui.ts b/src/main/runtime/rpc/methods/client-ui.ts
index 6e9d57050..0098722c1 100644
--- a/src/main/runtime/rpc/methods/client-ui.ts
+++ b/src/main/runtime/rpc/methods/client-ui.ts
@@ -10,7 +10,6 @@ const UnknownRecordArray = z.array(UnknownRecord)
 const WorktreeCardProperty = z.enum([
   'status',
   'unread',
-  'branch',
   'ci',
   'issue',
   'linear-issue',
diff --git a/src/renderer/src/components/sidebar/SidebarWorkspaceOptionsMenu.tsx b/src/renderer/src/components/sidebar/SidebarWorkspaceOptionsMenu.tsx
index 32f32ae86..bf27e5dcd 100644
--- a/src/renderer/src/components/sidebar/SidebarWorkspaceOptionsMenu.tsx
+++ b/src/renderer/src/components/sidebar/SidebarWorkspaceOptionsMenu.tsx
@@ -35,7 +35,6 @@ const GROUP_BY_OPTIONS = [
 ] as const
 
 const PROPERTY_OPTIONS: { id: WorktreeCardProperty; label: string }[] = [
-  { id: 'branch', label: 'Branch name' },
   { id: 'issue', label: 'GitHub ticket' },
   { id: 'linear-issue', label: 'Linear issue' },
   { id: 'pr', label: 'PR/MR link' },
diff --git a/src/renderer/src/components/sidebar/WorktreeCard.quick-actions.test.tsx b/src/renderer/src/components/sidebar/WorktreeCard.quick-actions.test.tsx
index cfe4aa382..63b37973a 100644
--- a/src/renderer/src/components/sidebar/WorktreeCard.quick-actions.test.tsx
+++ b/src/renderer/src/components/sidebar/WorktreeCard.quick-actions.test.tsx
@@ -125,41 +125,6 @@ describe('WorktreeCard quick actions', () => {
     expect(markup).toContain('data-workspace-board-preserve-open=""')
   })
 
-  it('hides the branch name from workspace card metadata by default', () => {
-    const markup = renderToStaticMarkup(
-      <WorktreeCard
-        worktree={makeWorktree({
-          displayName: 'Visible workspace',
-          branch: 'refs/heads/feature/secret-ref'
-        })}
-        repo={makeRepo()}
-        isActive={false}
-      />
-    )
-
-    expect(markup).toContain('Visible workspace')
-    expect(markup).not.toContain('feature/secret-ref')
-    expect(markup).not.toContain('secret-ref')
-  })
-
-  it('renders the branch name when the Branch name property is enabled', () => {
-    worktreeCardProperties = ['status', 'unread', 'branch']
-
-    const markup = renderToStaticMarkup(
-      <WorktreeCard
-        worktree={makeWorktree({
-          displayName: 'Visible workspace',
-          branch: 'refs/heads/feature/show-ref'
-        })}
-        repo={makeRepo()}
-        isActive={false}
-      />
-    )
-
-    expect(markup).toContain('Visible workspace')
-    expect(markup).toContain('feature/show-ref')
-  })
-
   it('shows delete as the top-right quick action for an inactive workspace', () => {
     const markup = renderToStaticMarkup(
       <WorktreeCard worktree={makeWorktree()} repo={makeRepo()} isActive={false} />
diff --git a/src/renderer/src/components/sidebar/WorktreeCard.tsx b/src/renderer/src/components/sidebar/WorktreeCard.tsx
index ec70021a7..45dc3d546 100644
--- a/src/renderer/src/components/sidebar/WorktreeCard.tsx
+++ b/src/renderer/src/components/sidebar/WorktreeCard.tsx
@@ -254,7 +254,6 @@ const WorktreeCard = React.memo(function WorktreeCard({
   const showLinearIssue = cardProps.includes('linear-issue')
   const showComment = cardProps.includes('comment')
   const showPorts = cardProps.includes('ports')
-  const showBranch = cardProps.includes('branch')
 
   // Skip hosted-review fetches when the corresponding card sections are hidden.
   // This preference is purely presentational, so background refreshes would
@@ -416,7 +415,8 @@ const WorktreeCard = React.memo(function WorktreeCard({
   )
   // Why: deleting the active/current workspace or one with live activity is a
   // disruptive hover action; keep the quick action delete-only and passive.
-  const showDeleteQuickAction = !isCurrentWorktree && !hasActiveActivity && !worktree.isMainWorktree
+  const showDeleteQuickAction =
+    !isCurrentWorktree && !hasActiveActivity && !worktree.isMainWorktree
   const handleWorkspaceQuickAction = useCallback(
     (event: React.MouseEvent<HTMLButtonElement>) => {
       event.preventDefault()
@@ -624,9 +624,10 @@ const WorktreeCard = React.memo(function WorktreeCard({
             )}
 
             {/* Why: weight alone carries the unread signal; color stays
-                 at text-foreground in both states so the title remains
-                 the card's primary scan target even when optional branch
-                 metadata is hidden. */}
+                 at text-foreground in both states so the title keeps
+                 hierarchy against the muted branch row below (muting the
+                 title as well flattened the card — same reasoning as the
+                 repo chip comment below). */}
             <div
               className={cn(
                 'text-[12px] truncate leading-tight text-foreground',
@@ -642,8 +643,8 @@ const WorktreeCard = React.memo(function WorktreeCard({
 
             {/* Why: the primary worktree (the original clone directory) cannot be
                  deleted via `git worktree remove`. Placing this badge next to the
-                 name keeps that constraint visible even when branch metadata is
-                 hidden by the user's card-property choice. */}
+                 name makes it immediately visible and avoids confusion with the
+                 branch name "main" shown below. */}
             {worktree.isMainWorktree && !isFolder && (
               <Tooltip>
                 <TooltipTrigger asChild>
@@ -734,11 +735,11 @@ const WorktreeCard = React.memo(function WorktreeCard({
               >
                 {repo ? getRepoKindLabel(repo) : 'Folder'}
               </Badge>
-            ) : showBranch && branch ? (
+            ) : (
               <span className="min-w-0 text-[11px] text-muted-foreground truncate leading-none">
                 {branch}
               </span>
-            ) : null}
+            )}
 
             {/* Why: the conflict operation (merge/rebase/cherry-pick) is the
                  only signal that the worktree is in an incomplete operation state.
diff --git a/src/renderer/src/components/sidebar/WorktreeList.lineage-child-card.test.ts b/src/renderer/src/components/sidebar/WorktreeList.lineage-child-card.test.ts
index 355bd89ea..44e681db6 100644
--- a/src/renderer/src/components/sidebar/WorktreeList.lineage-child-card.test.ts
+++ b/src/renderer/src/components/sidebar/WorktreeList.lineage-child-card.test.ts
@@ -249,23 +249,5 @@ describe('WorktreeList lineage child card renderer', () => {
     expect(agentRowIndex).toBeGreaterThan(childStart)
     expect(childToggleIndex).toBeGreaterThan(childStart)
     expect(agentRowIndex).toBeLessThan(childToggleIndex)
-    expect(markup).not.toContain('child-branch')
-    expect(markup).not.toContain('grandchild-branch')
-  })
-
-  it('renders nested lineage branch labels when the Branch name property is enabled', async () => {
-    setLineageFixtureState()
-    mockStore.state.worktreeCardProperties = ['status', 'inline-agents', 'branch']
-    const { default: WorktreeList } = await import('./WorktreeList')
-
-    const markup = renderToStaticMarkup(
-      React.createElement(WorktreeList, {
-        scrollOffsetRef: { current: 0 },
-        scrollAnchorRef: { current: null }
-      })
-    )
-
-    expect(markup).toContain('child-branch')
-    expect(markup).toContain('grandchild-branch')
   })
 })
diff --git a/src/renderer/src/components/sidebar/WorktreeList.tsx b/src/renderer/src/components/sidebar/WorktreeList.tsx
index 67bd95975..96dae75de 100644
--- a/src/renderer/src/components/sidebar/WorktreeList.tsx
+++ b/src/renderer/src/components/sidebar/WorktreeList.tsx
@@ -25,7 +25,6 @@ import {
   useWorktreeMap
 } from '@/store/selectors'
 import WorktreeCard from './WorktreeCard'
-import { branchDisplayName } from './WorktreeCardHelpers'
 import WorktreeCardAgents from './WorktreeCardAgents'
 import { SshDisconnectedDialog } from './SshDisconnectedDialog'
 import { WorktreeActivityStatusIndicator } from './WorktreeActivityStatusIndicator'
@@ -126,6 +125,7 @@ import {
   pruneWorktreeSelection,
   updateWorktreeSelection
 } from './worktree-multi-selection'
+import { branchDisplayName } from './WorktreeCardHelpers'
 import { callRuntimeRpc, getActiveRuntimeTarget } from '@/runtime/runtime-rpc-client'
 import { getRepoHeaderCreateState } from './repo-header-create-state'
 import type { PendingSidebarWorktreeReveal } from '@/store/slices/ui'
@@ -2162,10 +2162,6 @@ const VirtualizedWorktreeViewport = React.memo(function VirtualizedWorktreeViewp
 
             const renderLineageChildCard = (child: WorktreeItemRow) => {
               const isActive = activeWorktreeId === child.worktree.id
-              const childRepo = child.repo
-              const showChildRepoBadge = childRepo !== undefined && groupBy !== 'repo'
-              const showChildBranch =
-                cardProps.includes('branch') && child.worktree.branch.trim() !== ''
               const handleClick = (event: React.MouseEvent<HTMLDivElement>) => {
                 event.preventDefault()
                 event.stopPropagation()
@@ -2215,26 +2211,22 @@ const VirtualizedWorktreeViewport = React.memo(function VirtualizedWorktreeViewp
                         <div className="truncate text-[12px] leading-tight text-foreground">
                           {child.worktree.displayName}
                         </div>
-                        {showChildRepoBadge || showChildBranch ? (
-                          <div className="mt-1 flex min-w-0 items-center gap-1.5">
-                            {showChildRepoBadge && childRepo ? (
-                              <span className="flex h-[16px] shrink-0 items-center gap-1.5 rounded-[4px] border border-border bg-accent px-1.5 text-[10px] font-semibold leading-none text-foreground dark:bg-accent/50 dark:border-border/60">
-                                <span
-                                  className="size-1.5 rounded-full"
-                                  style={{ backgroundColor: childRepo.badgeColor }}
-                                />
-                                <span className="max-w-[6rem] truncate lowercase">
-                                  {childRepo.displayName}
-                                </span>
+                        <div className="mt-1 flex min-w-0 items-center gap-1.5">
+                          {child.repo && groupBy !== 'repo' ? (
+                            <span className="flex h-[16px] shrink-0 items-center gap-1.5 rounded-[4px] border border-border bg-accent px-1.5 text-[10px] font-semibold leading-none text-foreground dark:bg-accent/50 dark:border-border/60">
+                              <span
+                                className="size-1.5 rounded-full"
+                                style={{ backgroundColor: child.repo.badgeColor }}
+                              />
+                              <span className="max-w-[6rem] truncate lowercase">
+                                {child.repo.displayName}
                               </span>
-                            ) : null}
-                            {showChildBranch ? (
-                              <span className="truncate text-[10.5px] leading-none text-muted-foreground">
-                                {branchDisplayName(child.worktree.branch)}
-                              </span>
-                            ) : null}
-                          </div>
-                        ) : null}
+                            </span>
+                          ) : null}
+                          <span className="truncate text-[10.5px] leading-none text-muted-foreground">
+                            {branchDisplayName(child.worktree.branch)}
+                          </span>
+                        </div>
                         {child.worktree.linkedIssue || child.worktree.comment ? (
                           <div className="mt-1.5 truncate text-[10.5px] leading-tight text-muted-foreground">
                             {child.worktree.linkedIssue ? (
diff --git a/src/renderer/src/store/slices/ui.test.ts b/src/renderer/src/store/slices/ui.test.ts
index 1311fc938..fc234b392 100644
--- a/src/renderer/src/store/slices/ui.test.ts
+++ b/src/renderer/src/store/slices/ui.test.ts
@@ -547,19 +547,6 @@ describe('createUISlice hydratePersistedUI', () => {
     expect(store.getState().worktreeCardProperties).toEqual(expected)
     expect(setUI).toHaveBeenCalledWith({ worktreeCardProperties: expected })
   })
-
-  it('persists Branch name as an opt-in card property', () => {
-    const setUI = vi.fn().mockResolvedValue(undefined)
-    vi.stubGlobal('window', { api: { ui: { set: setUI } } })
-    const store = createUIStore()
-
-    store.getState().toggleWorktreeCardProperty('branch')
-
-    expect(store.getState().worktreeCardProperties).toContain('branch')
-    expect(setUI).toHaveBeenCalledWith({
-      worktreeCardProperties: expect.arrayContaining(['status', 'unread', 'branch'])
-    })
-  })
 })
 
 describe('createUISlice settings navigation', () => {
diff --git a/src/shared/constants.test.ts b/src/shared/constants.test.ts
index 8b120c743..0f0215128 100644
--- a/src/shared/constants.test.ts
+++ b/src/shared/constants.test.ts
@@ -1,9 +1,5 @@
 import { describe, expect, it } from 'vitest'
-import {
-  getDefaultPrimarySelectionMiddleClickPaste,
-  getDefaultSettings,
-  getDefaultUIState
-} from './constants'
+import { getDefaultPrimarySelectionMiddleClickPaste, getDefaultSettings } from './constants'
 
 describe('getDefaultSettings', () => {
   it('enables gitignored file decorations by default', () => {
@@ -40,9 +36,3 @@ describe('getDefaultPrimarySelectionMiddleClickPaste', () => {
     expect(getDefaultPrimarySelectionMiddleClickPaste('win32')).toBe(false)
   })
 })
-
-describe('getDefaultUIState', () => {
-  it('keeps branch names hidden from workspace cards by default', () => {
-    expect(getDefaultUIState().worktreeCardProperties).not.toContain('branch')
-  })
-})
diff --git a/src/shared/types.ts b/src/shared/types.ts
index 8fe5ba7b1..49e43ed3c 100644
--- a/src/shared/types.ts
+++ b/src/shared/types.ts
@@ -2025,9 +2025,6 @@ export type NotificationPermissionStatusResult = {
 export type WorktreeCardProperty =
   | 'status'
   | 'unread'
-  // Git branch metadata shown on workspace cards. Hidden by default because
-  // workspace names already carry the primary identity for most lists.
-  | 'branch'
   // Legacy persisted preference. CI status is now represented by linked PR metadata.
   | 'ci'
   // GitHub issue metadata shown on workspace cards.
diff --git a/src/shared/worktree-card-properties.ts b/src/shared/worktree-card-properties.ts
index a9ccf5ad8..ea405c3d4 100644
--- a/src/shared/worktree-card-properties.ts
+++ b/src/shared/worktree-card-properties.ts
@@ -18,7 +18,6 @@ export const DEFAULT_WORKTREE_CARD_PROPERTIES: WorktreeCardProperty[] = [
 const WORKTREE_CARD_PROPERTY_ORDER: WorktreeCardProperty[] = [
   'status',
   'unread',
-  'branch',
   'ci',
   'issue',
   'linear-issue',