test: expand test coverage and extract worktree logic into testable module (#108)

Add comprehensive tests for worktree parsing, GitHub check status derivation,
hooks YAML parsing, persistence store, layout serialization, store cascades,
and terminal helpers. Extract pure functions from worktrees.ts into
worktree-logic.ts for better testability.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jinjing
2026-03-25 22:34:20 -07:00
committed by GitHub
co-authored by Claude Opus 4.6
parent 951ab72d7b
commit 69978c93f5
15 changed files with 2212 additions and 109 deletions
+179 -1
View File
@@ -1,5 +1,5 @@
import { describe, expect, it } from 'vitest'
import { deriveCheckStatus, mapPRState } from './client'
import { deriveCheckStatus, mapPRState, mapCheckStatus, mapCheckConclusion } from './client'
describe('mapPRState', () => {
it('returns draft when an open PR is marked as draft', () => {
@@ -11,6 +11,24 @@ describe('mapPRState', () => {
expect(mapPRState('CLOSED', true)).toBe('closed')
expect(mapPRState('OPEN')).toBe('open')
})
it('handles lowercase inputs', () => {
expect(mapPRState('merged')).toBe('merged')
expect(mapPRState('closed')).toBe('closed')
expect(mapPRState('open')).toBe('open')
})
it('returns open for undefined state', () => {
expect(mapPRState(undefined as unknown as string)).toBe('open')
})
it('returns open for null state', () => {
expect(mapPRState(null as unknown as string)).toBe('open')
})
it('returns open for unknown state', () => {
expect(mapPRState('UNKNOWN')).toBe('open')
})
})
describe('deriveCheckStatus', () => {
@@ -19,6 +37,10 @@ describe('deriveCheckStatus', () => {
expect(deriveCheckStatus([])).toBe('neutral')
})
it('returns neutral for undefined input', () => {
expect(deriveCheckStatus(undefined)).toBe('neutral')
})
it('returns failure when a failed check is present', () => {
expect(deriveCheckStatus([{ status: 'QUEUED' }, { conclusion: 'FAILURE' }])).toBe('failure')
})
@@ -32,4 +54,160 @@ describe('deriveCheckStatus', () => {
'success'
)
})
it('returns failure when mixed success and failure', () => {
expect(deriveCheckStatus([{ conclusion: 'SUCCESS' }, { conclusion: 'FAILURE' }])).toBe(
'failure'
)
})
it('returns pending when mixed success and pending', () => {
expect(deriveCheckStatus([{ conclusion: 'SUCCESS' }, { status: 'QUEUED' }])).toBe('pending')
})
it('returns success when all checks succeed', () => {
expect(
deriveCheckStatus([
{ conclusion: 'SUCCESS' },
{ conclusion: 'SUCCESS' },
{ conclusion: 'SUCCESS' }
])
).toBe('success')
})
it('returns failure when a single failure is among many successes', () => {
expect(
deriveCheckStatus([
{ conclusion: 'SUCCESS' },
{ conclusion: 'SUCCESS' },
{ conclusion: 'FAILURE' },
{ conclusion: 'SUCCESS' }
])
).toBe('failure')
})
it('returns failure for TIMED_OUT conclusion', () => {
expect(deriveCheckStatus([{ conclusion: 'SUCCESS' }, { conclusion: 'TIMED_OUT' }])).toBe(
'failure'
)
})
it('returns failure for CANCELLED conclusion', () => {
expect(deriveCheckStatus([{ conclusion: 'CANCELLED' }])).toBe('failure')
})
it('handles checks with state field instead of conclusion (FAILURE)', () => {
expect(deriveCheckStatus([{ state: 'FAILURE' }])).toBe('failure')
})
it('handles checks with state field instead of conclusion (ERROR)', () => {
expect(deriveCheckStatus([{ state: 'ERROR' }])).toBe('failure')
})
it('handles checks with state field PENDING', () => {
expect(deriveCheckStatus([{ state: 'PENDING' }])).toBe('pending')
})
it('returns pending for QUEUED status', () => {
expect(deriveCheckStatus([{ status: 'QUEUED' }])).toBe('pending')
})
it('returns pending for PENDING status', () => {
expect(deriveCheckStatus([{ status: 'PENDING' }])).toBe('pending')
})
it('failure takes priority over pending', () => {
expect(
deriveCheckStatus([
{ status: 'IN_PROGRESS' },
{ conclusion: 'FAILURE' },
{ conclusion: 'SUCCESS' }
])
).toBe('failure')
})
})
describe('mapCheckStatus', () => {
it('maps PENDING to queued', () => {
expect(mapCheckStatus('PENDING')).toBe('queued')
})
it('maps QUEUED to queued', () => {
expect(mapCheckStatus('QUEUED')).toBe('queued')
})
it('maps IN_PROGRESS to in_progress', () => {
expect(mapCheckStatus('IN_PROGRESS')).toBe('in_progress')
})
it('maps SUCCESS to completed', () => {
expect(mapCheckStatus('SUCCESS')).toBe('completed')
})
it('maps any other value to completed', () => {
expect(mapCheckStatus('FAILURE')).toBe('completed')
expect(mapCheckStatus('UNKNOWN')).toBe('completed')
})
it('handles lowercase inputs', () => {
expect(mapCheckStatus('pending')).toBe('queued')
expect(mapCheckStatus('in_progress')).toBe('in_progress')
})
})
describe('mapCheckConclusion', () => {
it('maps SUCCESS to success', () => {
expect(mapCheckConclusion('SUCCESS')).toBe('success')
})
it('maps PASS to success', () => {
expect(mapCheckConclusion('PASS')).toBe('success')
})
it('maps FAILURE to failure', () => {
expect(mapCheckConclusion('FAILURE')).toBe('failure')
})
it('maps FAIL to failure', () => {
expect(mapCheckConclusion('FAIL')).toBe('failure')
})
it('maps CANCELLED to cancelled', () => {
expect(mapCheckConclusion('CANCELLED')).toBe('cancelled')
})
it('maps TIMED_OUT to timed_out', () => {
expect(mapCheckConclusion('TIMED_OUT')).toBe('timed_out')
})
it('maps SKIPPED to skipped', () => {
expect(mapCheckConclusion('SKIPPED')).toBe('skipped')
})
it('maps PENDING to pending', () => {
expect(mapCheckConclusion('PENDING')).toBe('pending')
})
it('maps QUEUED to pending', () => {
expect(mapCheckConclusion('QUEUED')).toBe('pending')
})
it('maps IN_PROGRESS to pending', () => {
expect(mapCheckConclusion('IN_PROGRESS')).toBe('pending')
})
it('maps NEUTRAL to neutral', () => {
expect(mapCheckConclusion('NEUTRAL')).toBe('neutral')
})
it('returns null for unknown values', () => {
expect(mapCheckConclusion('UNKNOWN')).toBeNull()
expect(mapCheckConclusion('FOO')).toBeNull()
})
it('handles lowercase inputs', () => {
expect(mapCheckConclusion('success')).toBe('success')
expect(mapCheckConclusion('failure')).toBe('failure')
expect(mapCheckConclusion('pending')).toBe('pending')
})
})
+2 -2
View File
@@ -185,7 +185,7 @@ export async function updatePRTitle(
}
}
function mapCheckStatus(state: string): PRCheckDetail['status'] {
export function mapCheckStatus(state: string): PRCheckDetail['status'] {
const s = state?.toUpperCase()
if (s === 'PENDING' || s === 'QUEUED') {
return 'queued'
@@ -196,7 +196,7 @@ function mapCheckStatus(state: string): PRCheckDetail['status'] {
return 'completed'
}
function mapCheckConclusion(state: string): PRCheckDetail['conclusion'] {
export function mapCheckConclusion(state: string): PRCheckDetail['conclusion'] {
const s = state?.toUpperCase()
if (s === 'SUCCESS' || s === 'PASS') {
return 'success'