refactor: deduplicate repository search entries (#13415)

This commit is contained in:
Neil 2026-08-09 18:31:36 -07:00 committed by GitHub
parent 65a5e8470a
commit 1e72534709
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 35 deletions

View File

@ -104,6 +104,13 @@ describe('RepositoryPane search entries', () => {
expect(matchesSettingsSearch('worktree path', entries)).toBe(true)
})
it('includes each project search section once', () => {
const entries = getRepositoryPaneSearchEntries(repo)
expect(entries.filter(({ title }) => title === 'Project Icon')).toHaveLength(1)
expect(entries.filter(({ title }) => title === 'Default Worktree Base')).toHaveLength(1)
})
it('omits project runtime search for remote or unsupported repos', () => {
expect(matchesSettingsSearch('project runtime', getRepositoryPaneSearchEntries(repo))).toBe(
false

View File

@ -185,41 +185,6 @@ export function getRepositoryPaneSearchEntries(
)
]
},
{
title: translate('auto.components.settings.repository.search.b24f00294a', 'Project Icon'),
description: translate(
'auto.components.settings.repository.search.a1f3a2bd47',
'Project icon and color used in the sidebar and tabs.'
),
keywords: [
repo.displayName,
...translateSearchKeyword(
'auto.components.settings.repository.search.6438a94c63',
'project icon'
),
...translateSearchKeyword(
'auto.components.settings.repository.search.b2546efab5',
'repository icon'
),
...translateSearchKeyword('auto.components.settings.repository.search.8d045419b1', 'color'),
...translateSearchKeyword('auto.components.settings.repository.search.6d8de2f090', 'hex'),
...translateSearchKeyword('auto.components.settings.repository.search.c1075178cf', 'badge'),
...translateSearchKeyword(
'auto.components.settings.repository.search.cb4b4de666',
'avatar'
),
...translateSearchKeyword(
'auto.components.settings.repository.search.9dc60d7f6d',
'github'
),
...translateSearchKeyword('auto.components.settings.repository.search.1e73e840ff', 'emoji'),
...translateSearchKeyword(
'auto.components.settings.repository.search.27733eb6c1',
'favicon'
)
]
},
...(isFolder ? [] : getRepositoryGitWorktreeSearchEntries(repo)),
...(isFolder
? []
: [...getRepositoryGitAuthorSearchEntries(repo), ...getRepositoryGitHooksSearchEntries(repo)])