perf(agent-status): strip terminal control bytes by run, not per character (#10866)

* perf(agent-status): strip terminal control bytes by run, not per character

stripTerminalControl built its result with a per-character `+=`, allocating a
fresh string for every retained character. The Command Code status detector
calls it four times per PTY chunk — the scan text, the chunk-boundary variant,
and both previous-text lengths — so an agent pane paid that on every write.

Control bytes are sparse in real output, so copy the spans between them instead:
2.3x-2.6x from 5 KiB to 106 KiB chunks. Output is byte-identical, checked
exhaustively over every string up to length 4 across a 13-symbol control/unicode
alphabet plus 200k random strings (224,831 inputs, 0 mismatches).

* docs(agent-status): condense the run-copy rationale comments

Review feedback: both comments walked through the implementation. Keep one line
of non-obvious rationale each, per the repo's comment guidelines.

Co-authored-by: Orca <help@stably.ai>

* test(agent-status): correct terminal strip benchmark

* test(agent-status): bound terminal strip benchmark

---------

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Neil
2026-07-27 02:20:56 -07:00
committed by GitHub
co-authored by Orca
parent e217ce60f2
commit 165e4e0d1b
3 changed files with 242 additions and 3 deletions
+7 -3
View File
@@ -126,15 +126,19 @@ function stripTerminalControl(data: string): string {
return data
}
const withoutAnsi = data.replace(ANSI_ESCAPE_RE, '').replace(INCOMPLETE_ANSI_ESCAPE_RE, '')
// Four calls per PTY chunk favor copying sparse intact runs over per-character concatenation.
let output = ''
let runStart = 0
for (let index = 0; index < withoutAnsi.length; index += 1) {
const code = withoutAnsi.charCodeAt(index)
if ((code <= 0x1f && code !== 0x0a && code !== 0x0d) || (code >= 0x7f && code <= 0x9f)) {
continue
if (index > runStart) {
output += withoutAnsi.slice(runStart, index)
}
runStart = index + 1
}
output += withoutAnsi[index]
}
return output
return runStart === 0 ? withoutAnsi : output + withoutAnsi.slice(runStart)
}
function terminalControlMayAffectText(data: string): boolean {