Venvs do not strip PYTHONPATH from inheritance. On multi-Python systems where PYTHONPATH points at a different Python's site-packages, transitive imports of compiled extensions (pydantic_core, chromadb_rust_bindings) load the wrong ABI and crash with ModuleNotFoundError on pydantic_core._pydantic_core. Place the pop in mempalace/__init__.py (instead of cli.py as the reporter proposed) so all entry points are covered: the mempalace shell command, python -m mempalace, and import mempalace from a library. Tests: tests/test_init.py runs the strip in a subprocess, parametrized over set / unset PYTHONPATH. Closes #1423.
39 lines
972 B
Python
39 lines
972 B
Python
"""__init__-level guards that must take effect before transitive imports."""
|
|
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"pythonpath",
|
|
[
|
|
"/tmp/some/leaked/path",
|
|
None,
|
|
],
|
|
)
|
|
def test_init_strips_leaked_pythonpath(pythonpath):
|
|
"""Package init must drop PYTHONPATH before compiled extensions load,
|
|
regardless of whether it was set in the parent environment."""
|
|
env = os.environ.copy()
|
|
if pythonpath is None:
|
|
env.pop("PYTHONPATH", None)
|
|
else:
|
|
env["PYTHONPATH"] = pythonpath
|
|
result = subprocess.run(
|
|
[
|
|
sys.executable,
|
|
"-c",
|
|
"import mempalace, os; print(repr(os.environ.get('PYTHONPATH')))",
|
|
],
|
|
env=env,
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
assert (
|
|
result.stdout.strip() == "None"
|
|
), f"PYTHONPATH not stripped (input was {pythonpath!r}): {result.stdout!r}"
|