背景:recall_count 被当成 V 值喂给衰减/遗忘逻辑,但每次召回命中都 ++, 造成「被召回 500+ 次所以永不遗忘」的虚高保命。实测 11576 条 recall_count>0、 2732 条 >=10,全是「出现在结果里」而非「被真正用上」。t_268b0353 注释早已 点明「被召回 ≠ 被验证」。 改法(AC1-6,禁部署): - LanceDB(arrow_schema) + sqlite(create/alter) 两侧同步新增 recall_seen_count / recall_verified_count(additive,不删旧列 recall_count) - 拆分两个写入点:召回命中(缓冲 Record→UpdateRecallBatch / 兜底 incrementRecallCount) → 写 recall_seen_count;正反馈(IncrementUseful)→ 写 recall_verified_count + useful_count - recall_count 冻结不再增长,保留只读(deprecated),衰减/遗忘只认 recall_verified_count - 排序去偏(lancedb_ipc Search importance)改用 recall_seen_count(观测/选择信号); 技能候选筛选(query_memories / GetSkillCandidates)改用 recall_seen_count - 单测 TestRecallSeenVerifiedIsolation / TestRecallCountFrozen:一次召回 seen++ verified 不增;一次正反馈 verified++;recall_count 冻结 - 实网取证:副本 LanceDB(禁部署)上跑真实 recall+反馈, BEFORE(0/0/0) → AFTER_RECALL(recall_count=0 seen=1 verified=0) → AFTER_VERIFY(0/1/1);schema 演进在副本上补列 4 个成功 go build/vet/test + rust build 全绿;E2E 蒸馏触发测试系既有 flake(stash 复现), 本改动无关。禁部署遵守:live /var/lib/memoryweave 未动,仅在副本上验过。
83 lines
3.2 KiB
Go
83 lines
3.2 KiB
Go
package storage
|
||
|
||
import (
|
||
"testing"
|
||
)
|
||
|
||
// TestRecallSeenVerifiedIsolation — GA-P0-2 (t_c6d41ac6) AC5
|
||
//
|
||
// 覆盖「一次召回 vs 一次正反馈」两条路径写不同字段:
|
||
//
|
||
// 召回命中(recall 缓冲/Update 的 recall_seen_count)→ 只加 recall_seen_count
|
||
// 正反馈(IncrementUseful) → 只加 recall_verified_count + useful_count
|
||
//
|
||
// 断言用相对增量(绝对值会被其它路径的计数干扰,见 P0-1 TestSplitNotUsefulFieldIsolation):
|
||
// 每次调用只 +1 到各自字段,其它字段(含冻结的 recall_count)必须原样不变。
|
||
func TestRecallSeenVerifiedIsolation(t *testing.T) {
|
||
mlc := NewMemLanceClient(nil)
|
||
mlc.mu.Lock()
|
||
mlc.memories["mem_recall_split_1"] = &memEntry{
|
||
ID: "mem_recall_split_1", RecallCount: 5, RecallSeenCount: 3, RecallVerifiedCount: 1,
|
||
}
|
||
mlc.mu.Unlock()
|
||
|
||
e := mlc.memories["mem_recall_split_1"]
|
||
|
||
// 路径1:一次召回命中 → 只加 recall_seen_count;recall_count(冻结) / verified / useful 不动
|
||
if err := mlc.Update("memories", "mem_recall_split_1", map[string]any{
|
||
"recall_seen_count": map[string]string{"$inc": "1"},
|
||
}); err != nil {
|
||
t.Fatalf("Update recall_seen_count err: %v", err)
|
||
}
|
||
if e.RecallSeenCount != 4 {
|
||
t.Fatalf("recall_seen_count 相对增量 +1,want 4 got %d", e.RecallSeenCount)
|
||
}
|
||
if e.RecallCount != 5 {
|
||
t.Fatalf("召回路径不得污染冻结的 recall_count,want 5 got %d", e.RecallCount)
|
||
}
|
||
if e.RecallVerifiedCount != 1 {
|
||
t.Fatalf("召回路径不得污染 recall_verified_count,want 1 got %d", e.RecallVerifiedCount)
|
||
}
|
||
if e.UsefulCount != 0 {
|
||
t.Fatalf("召回路径不得污染 useful_count,want 0 got %d", e.UsefulCount)
|
||
}
|
||
|
||
// 路径2:一次正反馈(用户点「有用」)→ 只加 recall_verified_count + useful_count;
|
||
// seen / recall_count(冻结) 不动
|
||
if err := mlc.IncrementUseful("mem_recall_split_1"); err != nil {
|
||
t.Fatalf("IncrementUseful err: %v", err)
|
||
}
|
||
if e.RecallVerifiedCount != 2 {
|
||
t.Fatalf("recall_verified_count 相对增量 +1,want 2 got %d", e.RecallVerifiedCount)
|
||
}
|
||
if e.UsefulCount != 1 {
|
||
t.Fatalf("useful_count 相对增量 +1,want 1 got %d", e.UsefulCount)
|
||
}
|
||
if e.RecallSeenCount != 4 {
|
||
t.Fatalf("正反馈不得污染 recall_seen_count,want 4 got %d", e.RecallSeenCount)
|
||
}
|
||
if e.RecallCount != 5 {
|
||
t.Fatalf("正反馈不得污染冻结的 recall_count,want 5 got %d", e.RecallCount)
|
||
}
|
||
}
|
||
|
||
// TestRecallCountFrozen — GA-P0-2 (t_c6d41ac6) AC3
|
||
// 旧 recall_count 冻结:IncrementUseful 不再 +recall_count(只 +verified),
|
||
// 保证「被召回 N 次所以永不遗忘」的虚高保命来源被切断。
|
||
func TestRecallCountFrozen(t *testing.T) {
|
||
mlc := NewMemLanceClient(nil)
|
||
mlc.mu.Lock()
|
||
mlc.memories["mem_frozen_1"] = &memEntry{ID: "mem_frozen_1", RecallCount: 42}
|
||
mlc.mu.Unlock()
|
||
|
||
e := mlc.memories["mem_frozen_1"]
|
||
if err := mlc.IncrementUseful("mem_frozen_1"); err != nil {
|
||
t.Fatalf("IncrementUseful err: %v", err)
|
||
}
|
||
if e.RecallCount != 42 {
|
||
t.Fatalf("recall_count 冻结,正反馈不得增长:want 42 got %d", e.RecallCount)
|
||
}
|
||
if e.RecallVerifiedCount != 1 {
|
||
t.Fatalf("recall_verified_count 应 +1:want 1 got %d", e.RecallVerifiedCount)
|
||
}
|
||
} |