From 216aa99d5d911d6f2e16b4ebf9f1d40fc2e96474 Mon Sep 17 00:00:00 2001 From: Ogulcan Celik Date: Wed, 8 Apr 2026 01:36:27 +0300 Subject: [PATCH] ci: add just ci for pull request checks --- .github/workflows/ci.yml | 24 ++++++++++++++++++++++++ CONTRIBUTING.md | 4 ++-- justfile | 7 +++++-- 3 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..4fef39fa --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,24 @@ +name: CI + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + check: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Install just + uses: extractions/setup-just@v3 + + - name: Install Rust + uses: dtolnay/rust-toolchain@stable + + - name: Restore cargo cache + uses: Swatinem/rust-cache@v2 + + - name: Run checks + run: just ci diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 915b2370..5a4784d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -48,10 +48,10 @@ If you plan to implement the change yourself, say that directly in the issue and ## Before submitting a PR -Run the project checks and make sure they pass. +Run the PR checks and make sure they pass. ```bash -just check +just ci ``` Do not open a PR that bypasses failing tests, formatting, or build errors. diff --git a/justfile b/justfile index 45f8fab4..0dbd3edd 100644 --- a/justfile +++ b/justfile @@ -5,10 +5,13 @@ test: cargo test python3 -m unittest scripts.test_changelog scripts.test_vendor_libghostty_vt -# Check formatting + run unit tests -check: +# Run PR CI checks +ci: cargo fmt --check cargo test + +# Check formatting + run unit tests + maintenance script tests +check: ci python3 -m unittest scripts.test_changelog scripts.test_vendor_libghostty_vt # Run the full local test suite