From c83aa45ec0fc14ce97143134c45bbc9d5b21d951 Mon Sep 17 00:00:00 2001
From: Henry Wang <hi@henry.wang>
Date: Fri, 9 Oct 2020 23:11:39 +0100
Subject: [PATCH] =?UTF-8?q?fix:=20BBC=20=E4=B8=AD=E6=96=87=E7=BD=91?=
 =?UTF-8?q?=E5=9B=BE=E7=89=87=20(#5837)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

close #5780
---
 lib/routes/bbc/utils.js | 42 ++++++++++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 15 deletions(-)

diff --git a/lib/routes/bbc/utils.js b/lib/routes/bbc/utils.js
index 8b3122d7d..8d472fc73 100644
--- a/lib/routes/bbc/utils.js
+++ b/lib/routes/bbc/utils.js
@@ -1,26 +1,34 @@
-const ProcessImage = ($, e, c) => {
+const cheerio = require('cheerio');
+const ProcessImage = ($, e, c, noscript = false) => {
     const img = $(e).find(c);
 
     if (img.length > 0) {
         let message;
+        // special handling for img wrapped in <noscript>
+        if (noscript) {
+            // eslint-disable-next-line no-unused-vars
+            const i = cheerio.load(img[0].children[0].data)('img')[0];
 
-        // handle cover image and lazy-loading images
-        if (img[0].attribs.src) {
-            message = `<figure><img alt='${img[0].attribs.alt ? img[0].attribs.alt : ''}' src='${img[0].attribs.src.replace(/(?<=\/news\/).*?(?=\/cpsprodpb)/, '600')}'><br><figcaption>`;
+            message = `<figure><img alt='${i.attribs.alt}' src='${i.attribs.src}'><br><figcaption>`;
         } else {
-            message = `<figure><img alt='${img[0].attribs['data-alt'] ? img[0].attribs['data-alt'] : ''}' src='${img[0].attribs['data-src'].replace(/(?<=\/news\/).*?(?=\/cpsprodpb)/, '600')}'><br><figcaption>`;
-        }
+            if (img[0].attribs.src) {
+                // handle cover image and lazy-loading images
+                message = `<figure><img alt='${img[0].attribs.alt ? img[0].attribs.alt : ''}' src='${img[0].attribs.src.replace(/(?<=\/news\/).*?(?=\/cpsprodpb)/, '600')}'><br><figcaption>`;
+            } else {
+                message = `<figure><img alt='${img[0].attribs['data-alt'] ? img[0].attribs['data-alt'] : ''}' src='${img[0].attribs['data-src'].replace(/(?<=\/news\/).*?(?=\/cpsprodpb)/, '600')}'><br><figcaption>`;
+            }
 
-        // add image caption
-        const figcaption = $(e).find('.media-caption__text');
-        if (figcaption.length > 0) {
-            message += `${$(figcaption[0]).text().trim()}`;
-        }
+            // add image caption
+            const figcaption = $(e).find('.media-caption__text');
+            if (figcaption.length > 0) {
+                message += `${$(figcaption[0]).text().trim()}`;
+            }
 
-        // add image copyright
-        const copyright = $(e).find('.story-image-copyright');
-        if (copyright.length > 0) {
-            message += ` ©${$(copyright[0]).text().trim()}`;
+            // add image copyright
+            const copyright = $(e).find('.story-image-copyright');
+            if (copyright.length > 0) {
+                message += ` ©${$(copyright[0]).text().trim()}`;
+            }
         }
 
         message += '</figcaption></figure>';
@@ -108,6 +116,10 @@ const ProcessFeed = ($, link) => {
         // handle lazy-loading images
         ProcessImage($, e, '.js-delayed-image-load');
 
+        ProcessImage($, e, 'div > div > div > img');
+
+        ProcessImage($, e, 'div > div > div > noscript', true);
+
         ProcessVideo($, e, 'figure.media-with-caption > div.player-with-placeholder');
 
         $(e).remove();