From 4ee95d9dcf3235017719bf054998bbd8eae611e2 Mon Sep 17 00:00:00 2001 From: Logan Rockmore Date: Fri, 13 Dec 2019 01:20:32 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20Fix=20the=20Dribbble=20urls=20so=20that?= =?UTF-8?q?=20they=20always=20work=20properly,=20e=E2=80=A6=20(#3580)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/routes/dribbble/utils.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/routes/dribbble/utils.js b/lib/routes/dribbble/utils.js index 71321641d..ac96e50e2 100644 --- a/lib/routes/dribbble/utils.js +++ b/lib/routes/dribbble/utils.js @@ -31,11 +31,11 @@ async function ProcessFeed(list, caches) { list.map(async (item) => { const $ = cheerio.load(item); - const itemUrlPath = - $('.animated-target').attr('href') || - $('.extras > a') - .attr('href') - .replace('/rebounds', ''); + // the rebounds link is used because all other links in the html could + // possibly point to /signup/new when loading the site while not logged in. + const itemUrlPath = $('.extras > a') + .attr('href') + .replace('/rebounds', ''); const itemUrl = url.resolve(host, itemUrlPath); const team = $('.attribution-team').text() ? ' for ' + $('.attribution-team a.url').text() : '';