From e1816e1a12d8b4a8a2c46d2b758a3ce07ee90f0d Mon Sep 17 00:00:00 2001 From: Innei Date: Sun, 27 Oct 2024 18:19:41 +0800 Subject: [PATCH] perf: resolve feed item select area performance problem (#1176) Signed-off-by: Innei --- apps/renderer/src/modules/feed-column/index.tsx | 13 ++++++++++++- apps/renderer/src/modules/feed-column/item.tsx | 5 +---- apps/renderer/src/modules/feed-column/list.tsx | 1 + 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/apps/renderer/src/modules/feed-column/index.tsx b/apps/renderer/src/modules/feed-column/index.tsx index eb7531a8f..553ad94a3 100644 --- a/apps/renderer/src/modules/feed-column/index.tsx +++ b/apps/renderer/src/modules/feed-column/index.tsx @@ -1,5 +1,6 @@ import { ActionButton } from "@follow/components/ui/button/index.js" import { Routes, views } from "@follow/constants" +import { useTypeScriptHappyCallback } from "@follow/hooks" import { useSubscribeElectronEvent } from "@follow/shared/event" import { stopPropagation } from "@follow/utils/dom" import { clamp, cn } from "@follow/utils/utils" @@ -24,6 +25,7 @@ import { useSubscriptionStore } from "~/store/subscription" import { useFeedUnreadStore } from "~/store/unread" import { WindowUnderBlur } from "../../components/ui/background" +import { getSelectedFeedIds, setSelectedFeedIds } from "./atom" import { FeedColumnHeader } from "./header" import { FeedList } from "./list" @@ -190,7 +192,16 @@ export function FeedColumn({ children, className }: PropsWithChildren<{ classNam ))} -
+
{ + if (!(e.target instanceof HTMLElement) || !e.target.closest("[data-feed-id]")) { + const nextSelectedFeedIds = getSelectedFeedIds() + setSelectedFeedIds(nextSelectedFeedIds.length === 0 ? nextSelectedFeedIds : []) + } + }, [])} + > {views.map((item, index) => (
diff --git a/apps/renderer/src/modules/feed-column/item.tsx b/apps/renderer/src/modules/feed-column/item.tsx index 57299bd95..d8c75f958 100644 --- a/apps/renderer/src/modules/feed-column/item.tsx +++ b/apps/renderer/src/modules/feed-column/item.tsx @@ -80,11 +80,8 @@ const FeedItemImpl = ({ view, feedId, className }: FeedItemProps) => { }) const [isContextMenuOpen, setIsContextMenuOpen] = useState(false) - useAnyPointDown((e) => { + useAnyPointDown(() => { setIsContextMenuOpen(false) - if (!(e.target instanceof HTMLElement) || !e.target.closest("[data-feed-id]")) { - setSelectedFeedIds([]) - } }) if (!feed) return null diff --git a/apps/renderer/src/modules/feed-column/list.tsx b/apps/renderer/src/modules/feed-column/list.tsx index 19811884b..0d8f08394 100644 --- a/apps/renderer/src/modules/feed-column/list.tsx +++ b/apps/renderer/src/modules/feed-column/list.tsx @@ -189,6 +189,7 @@ function FeedListImpl({ className, view }: { className?: string; view: number }) hitRate={10} onSelect={(e) => { const allChanged = [...e.added, ...e.removed] + setSelectedFeedIds((prev) => { const added = allChanged .map((el) => el.dataset.feedId)