From d766af4ba30e34a7fd75d09f020f51ff7d59bfbe Mon Sep 17 00:00:00 2001
From: lawvs <18554747+lawvs@users.noreply.github.com>
Date: Mon, 1 Sep 2025 19:09:27 +0800
Subject: [PATCH] fix: update AITaskModal to conditionally show settings tip

---
 .../ai-chat/components/layouts/AIChatContextBar.tsx |  2 +-
 .../modules/ai-task/components/ai-task-modal.tsx    | 13 +++++++++++--
 locales/ai/en.json                                  |  2 +-
 locales/ai/ja.json                                  |  2 +-
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/apps/desktop/layer/renderer/src/modules/ai-chat/components/layouts/AIChatContextBar.tsx b/apps/desktop/layer/renderer/src/modules/ai-chat/components/layouts/AIChatContextBar.tsx
index a398b1f39..cbb5c1c06 100644
--- a/apps/desktop/layer/renderer/src/modules/ai-chat/components/layouts/AIChatContextBar.tsx
+++ b/apps/desktop/layer/renderer/src/modules/ai-chat/components/layouts/AIChatContextBar.tsx
@@ -42,7 +42,7 @@ export const AIChatContextBar: Component<{ onSendShortcut?: (prompt: string) =>
       present({
         title: "New AI Task",
         canClose: true,
-        content: () => <AITaskModal />,
+        content: () => <AITaskModal showSettingsTip />,
       })
     }
 
diff --git a/apps/desktop/layer/renderer/src/modules/ai-task/components/ai-task-modal.tsx b/apps/desktop/layer/renderer/src/modules/ai-task/components/ai-task-modal.tsx
index 7df55ad71..964aec3b1 100644
--- a/apps/desktop/layer/renderer/src/modules/ai-task/components/ai-task-modal.tsx
+++ b/apps/desktop/layer/renderer/src/modules/ai-task/components/ai-task-modal.tsx
@@ -57,6 +57,10 @@ interface AITaskModalProps {
   task?: AITask // Existing task for editing (optional)
   prompt?: string
   onSubmit?: (data: TaskFormData) => void
+  /**
+   * Explicitly control whether to show the "open settings" tip/link.
+   */
+  showSettingsTip?: boolean
 }
 
 // Convert existing task data to form format or use defaults
@@ -129,7 +133,12 @@ const getDefaultFormData = (task?: AITask, prompt?: string): TaskFormData => {
   }
 }
 
-export const AITaskModal = ({ task, prompt, onSubmit }: AITaskModalProps) => {
+export const AITaskModal = ({
+  task,
+  prompt,
+  onSubmit,
+  showSettingsTip = false,
+}: AITaskModalProps) => {
   const { dismiss } = useCurrentModal()
   const createAITaskMutation = useCreateAITaskMutation()
   const updateAITaskMutation = useUpdateAITaskMutation()
@@ -277,7 +286,7 @@ export const AITaskModal = ({ task, prompt, onSubmit }: AITaskModalProps) => {
           {/* Form Actions */}
 
           <div className="flex items-center justify-end">
-            {!task && (
+            {showSettingsTip && (
               <button
                 type="button"
                 onClick={() => settingModalPresent("ai")}
diff --git a/locales/ai/en.json b/locales/ai/en.json
index d69e22a16..9ba7aeaf3 100644
--- a/locales/ai/en.json
+++ b/locales/ai/en.json
@@ -158,7 +158,7 @@
   "tasks.validation.prompt_required": "Prompt is required",
   "tasks.validation.title_max": "Title must be less than 50 characters",
   "tasks.validation.title_required": "Title is required",
-  "tasks.view_in_settings": "View scheduled tasks in Settings",
+  "tasks.view_in_settings": "View scheduled tasks",
   "token_usage.description": "Monitor your AI token consumption and limits",
   "token_usage.resets_at": "Resets at",
   "token_usage.title": "Token Usage",
diff --git a/locales/ai/ja.json b/locales/ai/ja.json
index 82932db04..4227ff9cc 100644
--- a/locales/ai/ja.json
+++ b/locales/ai/ja.json
@@ -126,7 +126,7 @@
   "tasks.validation.prompt_required": "プロンプトは必須です",
   "tasks.validation.title_max": "タイトルは50文字未満である必要があります",
   "tasks.validation.title_required": "タイトルは必須です",
-  "tasks.view_in_settings": "設定でスケジュールされたタスクを表示",
+  "tasks.view_in_settings": "スケジュールされたタスクを表示",
   "usage_analysis.active_session": "アクティブセッション",
   "usage_analysis.current_usage": "現在の使用状況",
   "usage_analysis.detailed_description": "AI使用パターンとインサイトの包括的概要",