From b6bccdf820a6527bb762f22ecfae4c79613f7035 Mon Sep 17 00:00:00 2001 From: Innei Date: Fri, 13 Jun 2025 23:13:57 +0800 Subject: [PATCH] refactor: update layout structure in SubviewLayout and enhance renderValue type in ResponsiveSelect - Modified SubviewLayout to use a div wrapper for improved layout management and added overflow handling. - Updated the renderValue prop type in ResponsiveSelect to accept a ResponsiveSelectItem instead of a string for better type safety. Signed-off-by: Innei --- .../src/modules/app-layout/subview/index.mobile.tsx | 9 +++++---- .../internal/components/src/ui/select/responsive.tsx | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/apps/desktop/layer/renderer/src/modules/app-layout/subview/index.mobile.tsx b/apps/desktop/layer/renderer/src/modules/app-layout/subview/index.mobile.tsx index c73ab8e5a..e38abd5bf 100644 --- a/apps/desktop/layer/renderer/src/modules/app-layout/subview/index.mobile.tsx +++ b/apps/desktop/layer/renderer/src/modules/app-layout/subview/index.mobile.tsx @@ -17,7 +17,7 @@ export const SubviewLayout = () => { }) return ( - <> +
{
- - - +
+ +
+
) } diff --git a/packages/internal/components/src/ui/select/responsive.tsx b/packages/internal/components/src/ui/select/responsive.tsx index ee125829b..db5b3ecb9 100644 --- a/packages/internal/components/src/ui/select/responsive.tsx +++ b/packages/internal/components/src/ui/select/responsive.tsx @@ -15,7 +15,7 @@ export interface ResponsiveSelectProps { onValueChange?: (value: string) => void placeholder?: string items: ResponsiveSelectItem[] - renderValue?: (value: string) => React.ReactNode + renderValue?: (item: ResponsiveSelectItem) => React.ReactNode renderItem?: (item: ResponsiveSelectItem) => React.ReactNode size?: "sm" | "default" @@ -69,7 +69,8 @@ export const ResponsiveSelect = ({ )} > - {(renderValue?.(valueInner) ?? valueToLabelMap[valueInner]) || ( + {(renderValue?.(items.find((item) => item.value === valueInner)!) ?? + valueToLabelMap[valueInner]) || ( {placeholder} )}