From 8b88e57e2ad225077bfb0140bec3bbd0f064f9cf Mon Sep 17 00:00:00 2001 From: Stephen Zhou <38493346+hyoban@users.noreply.github.com> Date: Mon, 25 Nov 2024 18:23:42 +0800 Subject: [PATCH] chore: use callback --- apps/renderer/src/hooks/biz/useNavigateEntry.ts | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/apps/renderer/src/hooks/biz/useNavigateEntry.ts b/apps/renderer/src/hooks/biz/useNavigateEntry.ts index 70d92c7a9..c8f509221 100644 --- a/apps/renderer/src/hooks/biz/useNavigateEntry.ts +++ b/apps/renderer/src/hooks/biz/useNavigateEntry.ts @@ -3,6 +3,7 @@ import { isMobile, useMobile } from "@follow/components/hooks/useMobile.js" import { useSheetContext } from "@follow/components/ui/sheet/context.js" import { FeedViewType } from "@follow/constants" import { isUndefined } from "es-toolkit/compat" +import { useCallback } from "react" import { setSidebarActiveView } from "~/atoms/sidebar" import { resetShowSourceContent } from "~/atoms/source-content" @@ -28,12 +29,15 @@ export type NavigateEntryOptions = Partial<{ export const useNavigateEntry = () => { const sheetContext = useSheetContext() const isMobile = useMobile() - return (navigateEntryOptions: NavigateEntryOptions) => { - navigateEntry(navigateEntryOptions) - if (isMobile) { - sheetContext?.dismiss() - } - } + return useCallback( + (options: NavigateEntryOptions) => { + navigateEntry(options) + if (isMobile && sheetContext) { + sheetContext.dismiss() + } + }, + [isMobile, sheetContext], + ) } export const navigateEntry = (options: NavigateEntryOptions) => {