From 1d2d58da88db07d01d1989fed5d88aed1290073a Mon Sep 17 00:00:00 2001
From: DIYgod <i@diygod.me>
Date: Tue, 25 Jun 2024 20:47:37 +0800
Subject: [PATCH] feat: lazy load feed list; remove virtuoso overscan

---
 src/renderer/src/modules/entry-column/index.tsx    |  1 -
 src/renderer/src/modules/feed-column/index.tsx     | 12 +++++++-----
 src/renderer/src/modules/settings/modal/layout.tsx |  2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/renderer/src/modules/entry-column/index.tsx b/src/renderer/src/modules/entry-column/index.tsx
index 929a419e5..b32a63886 100644
--- a/src/renderer/src/modules/entry-column/index.tsx
+++ b/src/renderer/src/modules/entry-column/index.tsx
@@ -120,7 +120,6 @@ export function EntryColumn() {
         )
       }, [isFetchingNextPage]),
     },
-    overscan: window.innerHeight,
     rangeChanged: handleRangeChange,
     totalCount: entries.totalCount,
     endReached: () => entries.hasNextPage && entries.fetchNextPage(),
diff --git a/src/renderer/src/modules/feed-column/index.tsx b/src/renderer/src/modules/feed-column/index.tsx
index c33f036e1..211a4f08a 100644
--- a/src/renderer/src/modules/feed-column/index.tsx
+++ b/src/renderer/src/modules/feed-column/index.tsx
@@ -161,12 +161,14 @@ export function FeedColumn() {
           {views.map((item, index) => (
             <section
               key={item.name}
-              className="shrink-0 snap-center overflow-y-auto"
+              className="min-h-full w-64 shrink-0 snap-center overflow-y-auto"
             >
-              <FeedList
-                className="flex min-h-full w-64 flex-col px-3 pb-6 text-sm"
-                view={index}
-              />
+              {active === index && (
+                <FeedList
+                  className="flex w-full flex-col px-3 pb-6 text-sm"
+                  view={index}
+                />
+              )}
             </section>
           ))}
         </m.div>
diff --git a/src/renderer/src/modules/settings/modal/layout.tsx b/src/renderer/src/modules/settings/modal/layout.tsx
index 231ee8bbf..b336b1427 100644
--- a/src/renderer/src/modules/settings/modal/layout.tsx
+++ b/src/renderer/src/modules/settings/modal/layout.tsx
@@ -59,7 +59,7 @@ export function SettingModalLayout(props: PropsWithChildren) {
     >
       {draggable && <div className="absolute inset-x-0 top-0 z-[1] h-8" onPointerDown={handleDrag} />}
       <div className="flex h-0 flex-1 bg-theme-tooltip-background">
-        <div className="w-44 border-r px-2 py-5">
+        <div className="w-44 border-r px-2 py-6">
           <div className="mb-4 flex h-8 items-center gap-2 px-4 font-bold">
             <Logo className="size-6" />
             {APP_NAME}