From 190a18e3324ffce6c714fd572b72a9216c4fcada Mon Sep 17 00:00:00 2001
From: "Kaffi Y." <gh@109cafe.com>
Date: Wed, 9 Oct 2024 17:08:04 +0800
Subject: [PATCH] fix: hidden menu item is not filtered out on native (#830)

---
 apps/renderer/src/lib/native-menu.ts | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/apps/renderer/src/lib/native-menu.ts b/apps/renderer/src/lib/native-menu.ts
index 43222abf4..f09f83f55 100644
--- a/apps/renderer/src/lib/native-menu.ts
+++ b/apps/renderer/src/lib/native-menu.ts
@@ -41,17 +41,13 @@ export const showNativeMenu = async (
   items: Array<NullableNativeMenuItem>,
   e?: MouseEvent | React.MouseEvent,
 ) => {
-  const nextItems = (items.filter(Boolean) as NativeMenuItem[]).map((item) => {
+  const nextItems = (items.filter((item) => item && !item.hide) as NativeMenuItem[]).map((item) => {
     if (item.type === "text") {
       return {
         ...item,
         shortcut: item.shortcut ? sortShortcutsString(item.shortcut) : undefined,
       }
     }
-
-    if (item.hide) {
-      return []
-    }
     return item
   }) as NativeMenuItem[]