From 072f503ba66d79c6be52bf4ba6a05b62dfb8207c Mon Sep 17 00:00:00 2001
From: Innei <tukon479@gmail.com>
Date: Tue, 17 Jun 2025 20:44:37 +0800
Subject: [PATCH] refactor(feed): optimize feed display and error handling

- Introduced a constant `SIZE` to manage the number of feeds displayed, improving maintainability.
- Updated the feed count display to use `list.data.feedCount` for accuracy.
- Enhanced error handling in `callNotFound` to specifically manage `FetchError` instances, improving robustness.

These changes aim to streamline feed management and enhance error reporting in the application.

Signed-off-by: Innei <tukon479@gmail.com>
---
 apps/ssr/client/pages/(main)/share/lists/[id]/index.tsx  | 9 ++++++---
 .../ssr/client/pages/(main)/share/users/[id]/metadata.ts | 2 +-
 apps/ssr/src/lib/not-found.ts                            | 9 +++++++--
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/apps/ssr/client/pages/(main)/share/lists/[id]/index.tsx b/apps/ssr/client/pages/(main)/share/lists/[id]/index.tsx
index 6704da2ef..68927a094 100644
--- a/apps/ssr/client/pages/(main)/share/lists/[id]/index.tsx
+++ b/apps/ssr/client/pages/(main)/share/lists/[id]/index.tsx
@@ -48,6 +48,8 @@ const FeedRow = memo<{ feed: Feed["feed"] }>(({ feed }) => {
   )
 })
 
+// Backend limit
+const SIZE = 5
 FeedRow.displayName = "FeedRow"
 
 export function Component() {
@@ -142,7 +144,7 @@ export function Component() {
                 <div className="divide-material-ultra-thick flex items-center divide-x">
                   <div className="px-4 text-center">
                     <div className="text-xl font-semibold text-zinc-900 dark:text-zinc-100">
-                      {list.data.list.feedIds?.length || 0}
+                      {list.data.feedCount || 0}
                     </div>
                     <div className="text-sm text-zinc-500 dark:text-zinc-400">
                       {(list.data.list.feedIds?.length || 0) > 1 ? "Feeds" : "Feed"}
@@ -189,13 +191,14 @@ export function Component() {
 
           <div className="grid gap-3 sm:grid-cols-1 lg:grid-cols-2">
             {listData.feedIds
-              ?.slice(0, 7)
+              ?.slice(0, SIZE)
               .map((feedId) => <FeedRow feed={feedMap[feedId]!} key={feedId} />)}
           </div>
 
-          {"feedCount" in list.data && list.data.feedCount > 7 && (
+          {"feedCount" in list.data && list.data.feedCount > SIZE && (
             <div className="mt-6 text-center">
               <button
+                type="button"
                 onClick={handleOpenInFollowApp}
                 className="hover:text-accent text-sm text-zinc-500 transition-colors dark:text-zinc-400"
               >
diff --git a/apps/ssr/client/pages/(main)/share/users/[id]/metadata.ts b/apps/ssr/client/pages/(main)/share/users/[id]/metadata.ts
index 9cf523bb6..457e5d554 100644
--- a/apps/ssr/client/pages/(main)/share/users/[id]/metadata.ts
+++ b/apps/ssr/client/pages/(main)/share/users/[id]/metadata.ts
@@ -20,7 +20,7 @@ export default defineMetadata(async ({ params, apiClient, origin }): Promise<Met
         id: isBizId(handle || "") ? handle : undefined,
       },
     })
-    .catch((e) => callNotFound(e.message))
+    .catch(callNotFound)
 
   const realUserId = profileRes.data.id
   const [subscriptionsRes, listsRes] = await Promise.allSettled([
diff --git a/apps/ssr/src/lib/not-found.ts b/apps/ssr/src/lib/not-found.ts
index d8ea4aca0..9ac68d804 100644
--- a/apps/ssr/src/lib/not-found.ts
+++ b/apps/ssr/src/lib/not-found.ts
@@ -1,8 +1,13 @@
+import { FetchError } from "ofetch"
+
 export class NotFoundError extends Error {
   constructor(reason: string) {
     super(`Page not found: ${reason}`)
   }
 }
-export const callNotFound = (reason: string) => {
-  throw new NotFoundError(reason)
+export const callNotFound = (e: any) => {
+  if (e instanceof FetchError && e.status === 404) {
+    throw new NotFoundError(e.message)
+  }
+  throw e
 }