* refactor(config): make [embedding] and [rerank] soft dependencies
Make [embedding] and [rerank] soft runtime dependencies so a
freshly-onboarded user can run EverOS end-to-end with only [llm]
configured. Previously the server refused to start without embedding,
locking out anyone who just wanted keyword-only search.
## Capability tiers
- Tier 1 ([llm] only) KEYWORD search, add/flush, md
writes, cascade sync
- Tier 2 ([llm] + [embedding]) + VECTOR / HYBRID search,
reflection, skill extraction,
backfill
- Tier 3 ([llm] + [embedding] + rerank) + AGENTIC search, knowledge
Tier upgrades require a server restart (capability accessors cache
for the process lifetime). Tier downgrades are read-safe: a Tier-3
user who drops [rerank] can still read/rename/delete existing
knowledge documents; only write/search endpoints return 422.
## What changed
- Component accessors — component/{embedding,rerank,llm}/accessor.py
are the single process-wide provider singletons. service/* never
maintains parallel singletons; it consumes get_embedding_capability()
/ get_rerank_capability() / get_llm_client() directly. Build-time
ValueError from the factory is logged as capability_build_failed
(was silently swallowed).
- Error mapping — ProviderNotConfiguredError -> 422 with everos.toml
section hints (never EVEROS_* env-var strings).
LanceDBMigrationError fails loud with escalating recovery guidance
(restart -> wipe index). LLMNotConfiguredError in search maps to
None for KEYWORD degradation.
- Nullable-vector LanceDB migration — schema v2 makes the vector
column nullable so Tier-1 rows can land without embeddings.
Migration is guarded by a cross-process memory_root_lock
(fcntl.flock + anyio.to_thread) and runs optimize() per table
after Phase-1 backfill to reclaim manifest bloat.
- Cascade — knowledge handlers register unconditionally (Tier-3 ->
Tier-2/1 downgrade no longer strands DELETE); embed-requiring
strategies use body-guards that check capability.available at
execution time. _TABLE_SPECS has an import-time drift assertion
against BUSINESS_SCHEMAS_WITH_VECTOR.
- `everos cascade backfill` CLI — Phase-1 (embed missing vectors) /
Phase-2 (emit synthetic events for cascaded processing) / Phase-3
(sync new skill files). Exit codes: 0 / 1 / 2 / 3 (server running
preflight) / 4 (COMPLETED_WITH_FAILURES — per-row failures rolled
up) / 130 (SIGINT). OMEConfig.crash_recovery_enabled=False in
backfill engines prevents stale-RUNNING rows re-enqueuing into a
smaller strategy registry.
- /health — reports capabilities + disabled_features per tier so ops
can distinguish "boots but degraded" from "boots and full".
- Presentation split — memory / service / infra never import typer /
click. TyperPresenter Protocol + run_backfill() live in
entrypoints/cli/commands/_backfill_cmd.py. Enforced by
import-linter.
- Startup hint — unconditional count_rows(filter="vector IS NULL")
sweep emits unbackfilled_memory_rows (event name + hint text
pinned) when Tier-1 rows exist. ParserLifespanProvider warms the
everalgo.parser import at boot so /health doesn't block on first
call.
- Knowledge upload UTF-8 short-circuit — _looks_like_utf8_text()
routes text/* mime and known plaintext extensions (md/txt/rst)
straight to UTF-8 decode instead of the parser. Prevents 503
Multimodal-not-configured when Tier 3 sans [multimodal] uploads a
markdown doc.
## Sync history with main (2 merges collapsed into this squash)
Merged origin/main at 6dcd3eb (v1.1.4 -> v1.2.0 adds OTel tracing,
/api/v2 alias, TracingLifespanProvider, per-cascade-embedding span
fix, memory-op instrumentation) and later at 42629df (PR #366
backfills v1.1.4 CWE-22 knowledge path traversal fix + cascade
retry-budget rework + errors.py -> core.errors.ExternalServiceError).
Key merge decisions:
- service/search.py adopts single wrap site — component.llm accessor
already applies UsageRecordingClient when observability is on;
service layer never keeps a parallel LLM singleton (Round-1 CR
rule: "service layer never maintains parallel singletons").
- Knowledge router prefix moved to /knowledge; create_app() mounts
it under both /api/v1 and /api/v2.
- Cascade retry classification uses ExternalServiceError from
core.errors (cascade/errors.py deleted). _MAX_TOTAL_RETRIES=12
cross-cycle budget preserved.
- Fixed backport typo: MemoryRoot.default() -> MemoryRoot.resolve()
(no .default() classmethod exists — main PR #366 shipped a broken
call).
## Verified layering
$ git grep -l "^import typer\|^from typer" src/everos/{memory,service,infra}
# empty
$ git grep -l "^import click\|^from click" src/everos/{memory,service,infra}
# empty
Memory / service / infra layers clean of CLI presentation libraries.
## Review history
Three rounds of Fable 5 (opus) code review across the pre-squash
commit history closed 38 findings total:
- Round 1: 10 findings (fail-loud migration, backfill hardening,
knowledge router gate scoping, SearchManager guards, profile
throttle lift)
- Round 2: 13 findings (hermetic test env, hot-reload doc drift,
knowledge handler registration, Phase 3 sync guarantee, Phase 2
idempotency, profile event-first path, OMEConfig crash-recovery
gate, cross-process migration lock, batch embed per-row fallback,
LanceDB optimize, typer/click layer split)
- Round 3: 15 Minor cleanups (accessor unification, marker revert,
episode query hygiene, --verbose subcommand, parser lifespan warm,
task-number scrub, temporal-overlap test, real-SIGINT slow mark,
4 design-note back-references)
Full per-round context lives in the PR description on GitHub.
## Test plan
- make lint (ruff + import-linter 3 contracts + assets +
deprecated-names + github-docs + datetime + OpenAPI drift)
- Hermetic env full pytest — 2027 passed / 7 deselected (7 = slow +
live_llm markers)
- Manual e2e across Tier 1/2/3 (21/21 assertions across v1/v2
double-mount and Tier 3 -> Tier 2 downgrade)
- /health reports correct capabilities + disabled_features per tier
## Known follow-ups
- .superpowers/sdd/followup-http-bridge.md (gitignored) — Path A for
spec §10's "backfill 期间 EverOS 完全可用" promise
- _TABLE_SCHEMA_VERSION docstring — v3+ migrations need a version
dispatch table
- extract_user_profile.py throttle-counter block — replace LanceDB
count_by_owner with a sqlite memcell count
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(review): close 3 blockers surfaced by round-4 review
N1. cluster_repo.find_cluster_id_for_member was cross-owner-unsafe.
Its reverse index (member_type, member_id) alone cannot disambiguate
two owners whose entry_id happens to collide — entry_id is
deliberately only per-owner unique (see entries.py:47:
'Cross-user uniqueness is handled at the database layer via a
composite <user_id>_<entry_id> field; it is not encoded into the
EntryId string itself'). Phase 2's _scan_all_rows crosses all
owners, so on any multi-owner root, same-day seq=1 episodes under
different owners would either false-hit each other's cluster or
be silently skipped from clustering. Add required (app_id,
project_id, owner_id) keyword args + JOIN Cluster (which already
carries scope) to filter by parent scope. Prior signature had zero
production callers except two the same PR just added, so the
API break is contained. Regression test: two owners persist a
cluster each around the same entry_id, each lookup resolves to
its own owner's cluster, a third owner's lookup returns None.
N2. Ctrl-C / EOF at the y/N prompt was landing on the generic
except Exception branch (exit 2 with rich traceback) instead of
the exit-130 interrupt path. Root cause: typer 0.15+ vendored
click under typer._click, so typer.Abort and the standalone
click.exceptions.Abort are distinct classes. The interrupt-branch
catch only listed the standalone one; every existing 'abort'
test was manually raising click.exceptions.Abort so the miss
was a false-positive guard rail. Widen the catch to
(typer.Abort, click.exceptions.Abort) and declare click as a
first-class dependency (it was only pulled in via uvicorn).
Regression test: raise real typer.Abort() at the confirm step
and assert exit 130 + INTERRUPTED banner.
N3. _looks_like_utf8_text used mime.startswith('text/'), which
caught text/html as well. HTML uploads then bypassed everalgo's
_aparse_html — losing clean_html_for_llm (strips <script>/<style>
/<nav>/<iframe> + HTML comments) and the 1 MiB output cap. A
40 MiB .html with <script> bodies and <!-- prompt injection -->
comments would flow straight into the extraction LLM. Replace
with explicit allowlist {text/plain, text/markdown, text/x-rst,
text/x-markdown}; text/html and any future text/* mime now
default to the parser path. Test matrix asserts text/html →
False (was regressed as True by the earlier commit).
Hermetic env full pytest: 2033 passed / 7 deselected (+6 tests
from these regressions).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(review): close round-4 major + minor + PR body errata
Round-4 review-driven cleanup. Blocker fixes (N1/N2/N3) landed in
561b5fe. This commit closes the remaining CONFIRMED items:
Major:
- J3 MemoryRoot.default() -> resolve() was a breaking public API
rename this branch introduced (main still has default()). Adds
default() as a backward-compat alias forwarding to resolve()
with DeprecationWarning; CHANGELOG entry under Unreleased.
- J4 episode_repo.list_by_owner_after_ts(limit=N) truncates in
fragment order (== insertion order), NOT newest-first. Docstring
now spells out the trap so a future caller passing limit for a
'newest N' window doesn't silently get the oldest N.
- J5.2 TyperPresenter.nothing_to_backfill picked colour via
'could not be read' in message — a domain wording change
would silently flip yellow -> green. Signature gains explicit
scan_failed: bool kwarg; CLI colour-picks off the flag.
- J5.5 phase_header was Protocol-declared but never dispatched
(run_backfill calls _print_phase_header directly). Removed the
dead Protocol method + both no-op implementations.
- J6.3 3 inline from everos.core.errors import ... inside
Phase 1/2/3 preflights promoted to a single top-level import.
- J7 subject-side embed failure was silently exit-0 because
rows_processed advanced whenever any side wrote. Now: a row with
a needed side still NULL counts as rows_failed (exit 4 =
COMPLETED_WITH_FAILURES). Gated on spec.subject_of + row.needs_*
+ row.subject_text so non-Episode tables and subject-empty rows
don't false-positive.
- J9 test_migration_cross_process.py did NOT actually test cross-
process (all 5 tests mock memory_root_lock). Renamed to
test_migration_lock_wiring.py; docstring now scopes it to
'lock-invocation wiring' and points at test_core/…/test_locking.py
for real flock coverage.
- J10 Phase 1 lacked the server-running preflight Phase 2/3 have.
--phase all against a live server would burn Phase 1 embed API
calls (real cost) before Phase 2 halted with exit 3. Phase 1 now
probes _probe_ome_lock_available first; regression test in
test_backfill_preflight.py; upgrade_path integration patches the
probe so its in-process 'server + backfill' scenario stays valid.
Minor:
- M1 knowledge upload with NUL byte or filename > 255 bytes UTF-8
used to raise ValueError/OSError at write_bytes → 500 with a
half-written md left on disk. _safe_original_filename now
rejects both up front with InvalidInputError (→ 400).
- M2 backfill optimize() now passes cleanup_older_than=timedelta(0)
so older manifest versions are physically pruned (previous call
compacted fragments but left the manifest chain on disk).
- M3 verify_business_schemas remediation text used to jump straight
to 'rm -rf ~/.everos/.index/lancedb'; now walks restart → wipe.
- M5 multimodal/accessor.py capability_build_failed warning added
so all four provider accessors log symmetrically (was silent).
- M7 test_knowledge_api parser-absence tests call
parser_available.cache_clear() around the sys.modules patch so
the lru_cache doesn't strand a stale True/False.
- M8 cascade_handler_embed_skipped (6 handlers) demoted INFO → DEBUG:
Tier 1 imports were generating N × 6 handler-info lines per md.
- M10.1 test_drift_scenario_would_raise was a tautology (compared
two hardcoded string sets, never touched the guard). Now
monkey-patches BUSINESS_SCHEMAS_WITH_VECTOR to a superset and
reloads _backfill, proving the import-time RuntimeError fires.
- M11 test_cascade_verbose_position subprocess.run calls gain
env= — scrubs EVEROS_* from the developer environment so the
same footgun as round-2 B1 doesn't re-appear inside subprocesses.
- M14 health() -> dict degraded the OpenAPI schema to
additionalProperties: true. Introduce HealthResponse +
HealthCapabilities Pydantic models so clients get real field
shape; docs/openapi.json regenerated.
- M16 routes/knowledge.py:_require_knowledge_capabilities docstring
claimed cascade.registry.build_handlers still gates
knowledge_topic/knowledge_document, contradicting
registry.py:177-194 (gate removed there, moved to HTTP layer).
Rewritten to describe the current design accurately.
Hermetic env full pytest: 2037 passed / 7 deselected.
Explicitly deferred to followup:
- J1 lazy multimodal client (needs everalgo signature change)
- J2 tier definition (knowledge = Tier 3 whole)
- J5.1/3/4 broader presentation-split refactor
- J6.1/2 backfill dispatch and _backfill_table refactor
- J8 Phase 1 keyset pagination for bulk migration OOM
- M4 flock timeout/waiting log/re-entry (core/persistence refactor)
- M6 UTF-8 codec strategy (BOM/UTF-16/GBK)
- M9 count_by_owner monotonicity (latent, INTERVAL=1 short-circuits)
- M13 --phase all multi-phase combined-outcome test coverage
- M15 PR-marker rationale comments (16 occurrences, all inert)
M12 was refuted (both event names exist).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
387 lines
14 KiB
Python
387 lines
14 KiB
Python
"""Verify per-endpoint scoping of the knowledge capability gate.
|
|
|
|
Task 11 (``cascade.registry.build_handlers``) gates the knowledge
|
|
cascade handlers off as an atomic pair when embed + rerank aren't
|
|
both available — a doc queued for a gated-off kind gets marked
|
|
permanently failed by the worker instead of ever reaching LanceDB.
|
|
Before this router gate existed, the HTTP layer had no idea any of
|
|
that happened: a Tier 1 user's upload returned 200 (the md write
|
|
always succeeds) while the document silently never became
|
|
searchable.
|
|
|
|
An earlier iteration attached the gate router-wide, which regressed
|
|
downgraded users: a client who dropped from Tier 3 → Tier 2/1 could
|
|
no longer even GET or DELETE their own docs, because the router-wide
|
|
dependency fired on every request. This module pins the corrected
|
|
scoping — writes and search stay gated (they can't succeed end-to-
|
|
end without the providers) while reads/deletes stay reachable so
|
|
users can inspect and clean up state they already have on disk.
|
|
|
|
Uses ``httpx.AsyncClient`` + ``ASGITransport`` (not
|
|
``fastapi.testclient.TestClient``) to match the project's established
|
|
exception-handler test convention (see ``tests/integration/test_api/
|
|
test_provider_error_mapping.py``). The knowledge router is mounted
|
|
standalone (no lifespan / full app) since the gate fires before any
|
|
body is even parsed — sub-dependency resolution runs ahead of
|
|
body/query/path validation in FastAPI's request handler, so a bare
|
|
request with no payload is enough to reach the gate on every route,
|
|
including the multipart upload endpoints.
|
|
|
|
For endpoints without a gate we stub the service call so the test
|
|
proves the request reached the handler (i.e. no 422 from the
|
|
missing-provider check), independent of MemoryRoot / SQLite setup.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import AsyncIterator
|
|
from typing import Any
|
|
|
|
import pytest
|
|
from fastapi import FastAPI
|
|
from httpx import ASGITransport, AsyncClient
|
|
|
|
import everos.component.embedding.accessor as embedding_accessor
|
|
import everos.component.rerank.accessor as rerank_accessor
|
|
from everos.component.embedding import EmbeddingCapability
|
|
from everos.component.rerank import RerankCapability
|
|
from everos.entrypoints.api.exception_handlers import register_handlers
|
|
from everos.entrypoints.api.routes import knowledge as knowledge_routes
|
|
|
|
# Endpoints that MUST return 422 when embed or rerank is missing.
|
|
# These paths either write new md that cascade will need to embed
|
|
# (POST/PUT) or run a search that requires both providers
|
|
# (POST /search). PATCH is deliberately NOT here — see the ungated
|
|
# list below.
|
|
_GATED_ENDPOINTS: list[tuple[str, str]] = [
|
|
("POST", "/api/v1/knowledge/documents"),
|
|
("PUT", "/api/v1/knowledge/documents/d_abcdef123456"),
|
|
("POST", "/api/v1/knowledge/search"),
|
|
]
|
|
|
|
# Endpoints that MUST stay reachable even when both capabilities are
|
|
# missing. All of these touch only md + SQLite state that already
|
|
# exists on disk — none of them need the embedding or rerank provider.
|
|
# PATCH is here because ``patch_document`` only rewrites md frontmatter
|
|
# and moves the doc directory when category changes; no embed or rerank
|
|
# code runs on that path. A user who downgrades from Tier 3 → Tier 1/2
|
|
# must still be able to rename or recategorize the documents they
|
|
# created while providers were configured.
|
|
_UNGATED_ENDPOINTS: list[tuple[str, str]] = [
|
|
("DELETE", "/api/v1/knowledge/documents/d_abcdef123456"),
|
|
("GET", "/api/v1/knowledge/documents"),
|
|
("GET", "/api/v1/knowledge/documents/d_abcdef123456"),
|
|
("GET", "/api/v1/knowledge/topics/d_abcdef123456_0"),
|
|
("GET", "/api/v1/knowledge/categories"),
|
|
]
|
|
|
|
|
|
def _build_app() -> FastAPI:
|
|
app = FastAPI()
|
|
register_handlers(app)
|
|
# Match production mounting: create_app() mounts the router under
|
|
# /api/v1 (and /api/v2). The router's own prefix is /knowledge, so
|
|
# the effective paths become /api/v1/knowledge/... — same shape the
|
|
# _GATED / _UNGATED constants below use.
|
|
app.include_router(knowledge_routes.router, prefix="/api/v1")
|
|
return app
|
|
|
|
|
|
@pytest.fixture
|
|
async def client() -> AsyncIterator[AsyncClient]:
|
|
app = _build_app()
|
|
transport = ASGITransport(app=app, raise_app_exceptions=False)
|
|
async with AsyncClient(transport=transport, base_url="http://test") as c:
|
|
yield c
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _capabilities_unavailable_by_default(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""Default both singletons to unavailable; tests opt into availability
|
|
per-capability via the fixtures below. Mirrors ``tests/unit/test_memory
|
|
/test_search/test_validate_components.py``.
|
|
"""
|
|
monkeypatch.setattr(
|
|
embedding_accessor, "_capability", EmbeddingCapability(provider=None)
|
|
)
|
|
monkeypatch.setattr(rerank_accessor, "_capability", RerankCapability(provider=None))
|
|
|
|
|
|
@pytest.fixture
|
|
def embed_available(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(
|
|
embedding_accessor, "_capability", EmbeddingCapability(provider=object())
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def rerank_available(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(
|
|
rerank_accessor, "_capability", RerankCapability(provider=object())
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def _stub_read_services(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""Replace every read/delete/list service call with a benign stub.
|
|
|
|
The tests in this module care only about whether the capability
|
|
gate fires. Ungated endpoints must reach their handler even when
|
|
providers are missing — but reaching the handler with no
|
|
MemoryRoot / SQLite setup would 500. Stubbing keeps the assertion
|
|
focused on the gate, not on end-to-end service behavior.
|
|
"""
|
|
from everos.service import knowledge as knowledge_service
|
|
|
|
async def _fake_delete_document(*args: Any, **kwargs: Any) -> Any:
|
|
return knowledge_service.DeleteResult(doc_id="d_abcdef123456", deleted_topics=0)
|
|
|
|
async def _fake_list_documents(*args: Any, **kwargs: Any) -> Any:
|
|
return knowledge_service.DocumentListResult(
|
|
documents=[], total=0, page=1, page_size=20
|
|
)
|
|
|
|
async def _fake_get_document(*args: Any, **kwargs: Any) -> Any:
|
|
from everos.component.utils.datetime import get_utc_now
|
|
|
|
now = get_utc_now()
|
|
return knowledge_service.DocumentDetail(
|
|
doc_id="d_abcdef123456",
|
|
category_id="General",
|
|
title="stub",
|
|
summary="stub",
|
|
source_name=None,
|
|
source_type=None,
|
|
original_file_path=None,
|
|
topics=[],
|
|
created_at=now,
|
|
updated_at=now,
|
|
)
|
|
|
|
async def _fake_get_topic(*args: Any, **kwargs: Any) -> Any:
|
|
from everos.component.utils.datetime import get_utc_now
|
|
|
|
now = get_utc_now()
|
|
return knowledge_service.TopicDetail(
|
|
topic_id="d_abcdef123456_0",
|
|
doc_id="d_abcdef123456",
|
|
category_id="General",
|
|
topic_name="stub",
|
|
topic_path="stub",
|
|
depth=0,
|
|
summary="stub",
|
|
content="",
|
|
content_labels=[],
|
|
parent_topic_id=None,
|
|
children_topic_ids=[],
|
|
created_at=now,
|
|
updated_at=now,
|
|
)
|
|
|
|
async def _fake_list_categories(*args: Any, **kwargs: Any) -> list[Any]:
|
|
return []
|
|
|
|
monkeypatch.setattr(knowledge_routes, "delete_document", _fake_delete_document)
|
|
monkeypatch.setattr(knowledge_routes, "list_documents", _fake_list_documents)
|
|
monkeypatch.setattr(knowledge_routes, "get_document", _fake_get_document)
|
|
monkeypatch.setattr(knowledge_routes, "get_topic", _fake_get_topic)
|
|
monkeypatch.setattr(knowledge_routes, "list_categories", _fake_list_categories)
|
|
|
|
|
|
@pytest.fixture
|
|
def _stub_patch_document(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""Stub ``patch_document`` to echo the requested title back.
|
|
|
|
Mirrors the real service contract: a title change lands in
|
|
``updated_fields`` and the caller sees the mutation reflected in
|
|
the response envelope. Keeps the assertion focused on the gate
|
|
(or lack of it) instead of on md / SQLite plumbing.
|
|
"""
|
|
from everos.component.utils.datetime import get_utc_now
|
|
from everos.service import knowledge as knowledge_service
|
|
|
|
captured: dict[str, Any] = {}
|
|
|
|
async def _fake_patch_document(
|
|
doc_id: str,
|
|
app_id: str,
|
|
project_id: str,
|
|
*,
|
|
title: str | None = None,
|
|
category_id: str | None = None,
|
|
) -> Any:
|
|
captured["title"] = title
|
|
captured["category_id"] = category_id
|
|
updated_fields: list[str] = []
|
|
if title is not None:
|
|
updated_fields.append("title")
|
|
if category_id is not None:
|
|
updated_fields.append("category_id")
|
|
return knowledge_service.PatchResult(
|
|
doc_id=doc_id,
|
|
updated_fields=updated_fields,
|
|
updated_at=get_utc_now(),
|
|
)
|
|
|
|
monkeypatch.setattr(knowledge_routes, "patch_document", _fake_patch_document)
|
|
|
|
|
|
async def _call(client: AsyncClient, method: str, path: str) -> Any:
|
|
return await client.request(method, path)
|
|
|
|
|
|
# ── Gated endpoints: 422 when embed missing (rerank also missing) ────────
|
|
|
|
|
|
@pytest.mark.parametrize("method,path", _GATED_ENDPOINTS)
|
|
async def test_gated_endpoint_422_when_embed_missing(
|
|
client: AsyncClient, method: str, path: str
|
|
) -> None:
|
|
"""Write/search endpoints must 422 with an embedding-specific message
|
|
when embedding is missing (check-embedding-first order per Task 12/13).
|
|
"""
|
|
resp = await _call(client, method, path)
|
|
assert resp.status_code == 422
|
|
body = resp.json()
|
|
assert body["error"]["code"] == "PROVIDER_NOT_CONFIGURED"
|
|
assert "embedding" in body["error"]["message"]
|
|
assert "knowledge" in body["error"]["message"]
|
|
|
|
|
|
# ── Gated endpoints: 422 when only rerank missing ───────────────────────
|
|
|
|
|
|
@pytest.mark.parametrize("method,path", _GATED_ENDPOINTS)
|
|
async def test_gated_endpoint_422_when_rerank_missing(
|
|
client: AsyncClient, method: str, path: str, embed_available: None
|
|
) -> None:
|
|
"""Write/search endpoints must 422 with a rerank-specific message
|
|
when only rerank is missing.
|
|
"""
|
|
resp = await _call(client, method, path)
|
|
assert resp.status_code == 422
|
|
body = resp.json()
|
|
assert body["error"]["code"] == "PROVIDER_NOT_CONFIGURED"
|
|
assert "rerank" in body["error"]["message"]
|
|
assert "knowledge" in body["error"]["message"]
|
|
|
|
|
|
# ── Ungated endpoints: must NOT 422 even with both capabilities missing ─
|
|
|
|
|
|
@pytest.mark.parametrize("method,path", _UNGATED_ENDPOINTS)
|
|
async def test_ungated_endpoint_not_422_without_any_capability(
|
|
client: AsyncClient,
|
|
method: str,
|
|
path: str,
|
|
_stub_read_services: None,
|
|
) -> None:
|
|
"""Read/list/delete endpoints must stay reachable even when neither
|
|
embed nor rerank is configured — a Tier-3 → Tier-1 downgrade must
|
|
not lock users out of inspecting and cleaning up their own state.
|
|
"""
|
|
resp = await _call(client, method, path)
|
|
assert resp.status_code != 422, (
|
|
f"{method} {path} returned 422 despite the gate being scoped away "
|
|
f"from read/delete endpoints; body={resp.text}"
|
|
)
|
|
|
|
|
|
# ── Ungated endpoints: also fine with only embed (Tier-2 downgrade) ─────
|
|
|
|
|
|
@pytest.mark.parametrize("method,path", _UNGATED_ENDPOINTS)
|
|
async def test_ungated_endpoint_not_422_with_embed_only(
|
|
client: AsyncClient,
|
|
method: str,
|
|
path: str,
|
|
embed_available: None,
|
|
_stub_read_services: None,
|
|
) -> None:
|
|
"""Tier-2 scenario (embed present, rerank missing): read/delete paths
|
|
must stay reachable — this is the concrete regression from the
|
|
router-wide-gate era that this fix targets.
|
|
"""
|
|
resp = await _call(client, method, path)
|
|
assert resp.status_code != 422, (
|
|
f"{method} {path} returned 422 despite rerank not being needed; "
|
|
f"body={resp.text}"
|
|
)
|
|
|
|
|
|
# ── Gated endpoints: pass the gate when both are available ──────────────
|
|
|
|
|
|
async def test_search_not_422_when_both_available(
|
|
client: AsyncClient,
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
embed_available: None,
|
|
rerank_available: None,
|
|
) -> None:
|
|
"""Both capabilities available: the gate must not fire on /search.
|
|
Stub the service call so the assertion is about the gate, not the
|
|
rest of the search pipeline (out of scope for this task).
|
|
"""
|
|
from everos.service import knowledge as knowledge_service
|
|
|
|
stub_result = knowledge_service.SearchKnowledgeResult(hits=[], total=0, took_ms=0.0)
|
|
|
|
async def _fake_search_knowledge(**kwargs: Any) -> Any:
|
|
return stub_result
|
|
|
|
monkeypatch.setattr(knowledge_routes, "search_knowledge", _fake_search_knowledge)
|
|
resp = await client.post(
|
|
"/api/v1/knowledge/search",
|
|
json={"query": "hello"},
|
|
)
|
|
assert resp.status_code != 422
|
|
|
|
|
|
# ── PATCH: metadata-only, must succeed regardless of provider config ────
|
|
|
|
|
|
_PATCH_BODY: dict[str, str] = {
|
|
"app_id": "app1",
|
|
"project_id": "proj1",
|
|
"title": "renamed",
|
|
}
|
|
|
|
|
|
async def test_knowledge_patch_document_succeeds_without_rerank(
|
|
client: AsyncClient,
|
|
embed_available: None,
|
|
_stub_patch_document: None,
|
|
) -> None:
|
|
"""Tier-2 scenario (embed configured, rerank missing): PATCH must
|
|
still land. Renaming an existing document does not touch rerank —
|
|
it only rewrites md frontmatter and upserts SQLite.
|
|
"""
|
|
resp = await client.patch(
|
|
"/api/v1/knowledge/documents/d_abcdef123456",
|
|
json=_PATCH_BODY,
|
|
)
|
|
assert resp.status_code == 200, resp.text
|
|
body = resp.json()
|
|
assert body["data"]["doc_id"] == "d_abcdef123456"
|
|
assert "title" in body["data"]["updated_fields"]
|
|
|
|
|
|
async def test_knowledge_patch_document_succeeds_without_any_capability(
|
|
client: AsyncClient,
|
|
_stub_patch_document: None,
|
|
) -> None:
|
|
"""Tier-1 scenario (no embed, no rerank): PATCH must still land.
|
|
Metadata-only edits are a cleanup verb — locking users out of
|
|
renaming their own docs after a full downgrade contradicts the
|
|
per-endpoint-gate contract documented on
|
|
``_require_knowledge_capabilities``.
|
|
"""
|
|
resp = await client.patch(
|
|
"/api/v1/knowledge/documents/d_abcdef123456",
|
|
json=_PATCH_BODY,
|
|
)
|
|
assert resp.status_code == 200, resp.text
|
|
body = resp.json()
|
|
assert body["data"]["doc_id"] == "d_abcdef123456"
|
|
assert "title" in body["data"]["updated_fields"]
|