From 560fb80b59fe5f033a911e38bebc87a3232a5234 Mon Sep 17 00:00:00 2001 From: zhanghui Date: Fri, 7 Aug 2026 15:18:56 +0800 Subject: [PATCH] docs(lancedb): mark the husk sweep removable once lance#8322 ships (#399) Upstream merged the fix on 2026-08-06: cleanup now removes the directories it empties, under the same 7-day / delete_unverified policy this sweep reimplements. It is not in any release yet (lancedb 0.34.0 embeds lance 8.0.0; the merge sits ahead of v11.0.0-beta.2), so the sweep stays -- but the next pin carrying it should delete this rather than keep a second copy of upstream's rule. That upgrade also collapses the documented horizon from ~14 days to ~7: lance drops the directory in the same pass that empties it, so our age gate stops stacking on top of theirs. Co-authored-by: zhanghui Co-authored-by: Claude Opus 5 (1M context) --- src/everos/core/persistence/lancedb/repository.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/everos/core/persistence/lancedb/repository.py b/src/everos/core/persistence/lancedb/repository.py index f118161..de79702 100644 --- a/src/everos/core/persistence/lancedb/repository.py +++ b/src/everos/core/persistence/lancedb/repository.py @@ -103,6 +103,16 @@ a day sits four orders of magnitude below it (tens of MB). Platform-wise only ext4 has a fixed inode budget at all; APFS and xfs allocate dynamically, and Windows is out of scope. The knob to reach for if this ever does bite is the optimize cooldown, not this threshold — see there. + +**When to remove this sweep** — lance-format/lance#8322 (merged 2026-08-06, +not in any release as of lancedb 0.34.0 / lance 8.0.0 — the merge sits ahead of +v11.0.0-beta.2) makes lance's own cleanup remove the directories it empties, +under this same 7-day / ``delete_unverified`` policy. Once a release carrying +it is pinned, delete :func:`_remove_empty_index_dirs` and its call site rather +than keep a second implementation of upstream's rule. That upgrade also halves +the horizon above: lance drops the directory in the pass that empties it, so +our age gate stops stacking on top of theirs and the steady state goes from +~14 days back to ~7. """ _HUSK_SWEEP_TIMEOUT_SECONDS = 60.0